Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: media/filters/ffmpeg_audio_decoder.cc

Issue 1041353002: media-internals: Differentiate error, info, and debug log messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviewer comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/ffmpeg_audio_decoder.cc
diff --git a/media/filters/ffmpeg_audio_decoder.cc b/media/filters/ffmpeg_audio_decoder.cc
index ae4f3fb52e17cad26ce7fb10d76c27ceafceb913..a302e41138e8a900c871a847281500fa2cfd5ac8 100644
--- a/media/filters/ffmpeg_audio_decoder.cc
+++ b/media/filters/ffmpeg_audio_decoder.cc
@@ -263,11 +263,11 @@ bool FFmpegAudioDecoder::FFmpegDecode(
<< "This is quite possibly a bug in the audio decoder not handling "
<< "end of stream AVPackets correctly.";
- MEDIA_LOG(log_cb_)
+ MEDIA_LOG(DEBUG, log_cb_)
<< "Dropping audio frame which failed decode with timestamp: "
- << buffer->timestamp().InMicroseconds() << " us, duration: "
- << buffer->duration().InMicroseconds() << " us, packet size: "
- << buffer->data_size() << " bytes";
+ << buffer->timestamp().InMicroseconds()
+ << " us, duration: " << buffer->duration().InMicroseconds()
+ << " us, packet size: " << buffer->data_size() << " bytes";
break;
}
@@ -293,9 +293,9 @@ bool FFmpegAudioDecoder::FFmpegDecode(
if (config_.codec() == kCodecAAC &&
av_frame_->sample_rate == 2 * config_.samples_per_second()) {
- MEDIA_LOG(log_cb_) << "Implicit HE-AAC signalling is being used."
- << " Please use mp4a.40.5 instead of mp4a.40.2 in"
- << " the mimetype.";
+ MEDIA_LOG(DEBUG, log_cb_) << "Implicit HE-AAC signalling is being"
+ << " used. Please use mp4a.40.5 instead of"
+ << " mp4a.40.2 in the mimetype.";
}
// This is an unrecoverable error, so bail out.
av_frame_unref(av_frame_.get());

Powered by Google App Engine
This is Rietveld 408576698