Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: media/filters/chunk_demuxer.h

Issue 1041353002: media-internals: Differentiate error, info, and debug log messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviewer comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/chunk_demuxer.h
diff --git a/media/filters/chunk_demuxer.h b/media/filters/chunk_demuxer.h
index c924683767b4fb755578d487a70e9c800cd290c0..1ef8d263755e695e4f7f344eeb4bc039a2cb0e54 100644
--- a/media/filters/chunk_demuxer.h
+++ b/media/filters/chunk_demuxer.h
@@ -151,8 +151,7 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
// encryption key is needed to decrypt the content.
// |enable_text| Process inband text tracks in the normal way when true,
// otherwise ignore them.
- // |log_cb| Run when parsing error messages need to be logged to the error
- // console.
+ // |log_cb| Run when the demuxer needs to emit MediaLog messages.
// |splice_frames_enabled| Indicates that it's okay to generate splice frames
// per the MSE specification. Renderers must understand DecoderBuffer's
// splice_timestamp() field.
@@ -360,7 +359,7 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
base::Closure open_cb_;
EncryptedMediaInitDataCB encrypted_media_init_data_cb_;
bool enable_text_;
- // Callback used to report error strings that can help the web developer
+ // Callback used to report log messages that can help the web developer
// figure out what is wrong with the content.
LogCB log_cb_;
scoped_refptr<MediaLog> media_log_;

Powered by Google App Engine
This is Rietveld 408576698