Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: content/renderer/media/android/media_source_delegate.cc

Issue 1041353002: media-internals: Differentiate error, info, and debug log messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviewer comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/media_log.h » ('j') | media/base/media_log.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/android/media_source_delegate.cc
diff --git a/content/renderer/media/android/media_source_delegate.cc b/content/renderer/media/android/media_source_delegate.cc
index 1a457465b2824b997423f237e88456c0867b5453..792148e9b7cebc303ce05e8fe587deb641b52aaa 100644
--- a/content/renderer/media/android/media_source_delegate.cc
+++ b/content/renderer/media/android/media_source_delegate.cc
@@ -40,9 +40,10 @@ const uint8 kVorbisPadding[] = { 0xff, 0xff, 0xff, 0xff };
namespace content {
-static void LogMediaSourceError(const scoped_refptr<media::MediaLog>& media_log,
- const std::string& error) {
- media_log->AddEvent(media_log->CreateMediaSourceErrorEvent(error));
+static void AddLogEntry(const scoped_refptr<media::MediaLog>& media_log,
+ media::MediaLog::MediaLogLevel level,
+ const std::string& message) {
+ media_log->AddEvent(media_log->CreateLogEvent(level, message));
}
MediaSourceDelegate::MediaSourceDelegate(
@@ -170,7 +171,7 @@ void MediaSourceDelegate::InitializeMediaSource(
base::Bind(&MediaSourceDelegate::OnDemuxerOpened, main_weak_this_)),
media::BindToCurrentLoop(base::Bind(
&MediaSourceDelegate::OnEncryptedMediaInitData, main_weak_this_)),
- base::Bind(&LogMediaSourceError, media_log_), media_log_, false));
+ base::Bind(&AddLogEntry, media_log_), media_log_, false));
// |this| will be retained until StopDemuxer() is posted, so Unretained() is
// safe here.
@@ -669,7 +670,7 @@ void MediaSourceDelegate::OnDemuxerOpened() {
return;
media_source_opened_cb_.Run(new media::WebMediaSourceImpl(
- chunk_demuxer_.get(), base::Bind(&LogMediaSourceError, media_log_)));
+ chunk_demuxer_.get(), base::Bind(&AddLogEntry, media_log_)));
}
void MediaSourceDelegate::OnEncryptedMediaInitData(
« no previous file with comments | « no previous file | media/base/media_log.h » ('j') | media/base/media_log.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698