media/formats/mp4/aac.cc - Issue 1041353002: media-internals: Differentiate error, info, and debug log messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mp4/aac.cc

Issue 1041353002: media-internals: Differentiate error, info, and debug log messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Attempt to fix android compile error Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/formats/mp4/aac.cc

diff --git a/media/formats/mp4/aac.cc b/media/formats/mp4/aac.cc

index 71dededf5526d539a68cfcb951cb64aa6de5cd2f..0d296c47ad0891eac7b4473791d3c54a4ef04b18 100644

--- a/media/formats/mp4/aac.cc

+++ b/media/formats/mp4/aac.cc

@@ -58,8 +58,8 @@ bool AAC::Parse(const std::vector<uint8>& data, const LogCB& log_cb) {

RCHECK(reader.ReadBits(5, &profile_));

}

- MEDIA_LOG(log_cb) << "Audio codec: mp4a.40."

- << std::hex << static_cast<int>(profile_);

+ MEDIA_LOG(log_cb, INFO) << "Audio codec: mp4a.40."

+ << std::hex << static_cast<int>(profile_);

RCHECK(SkipDecoderGASpecificConfig(&reader));

RCHECK(SkipErrorSpecificConfig());

« media/base/media_log.cc ('K') | « media/filters/stream_parser_factory.cc ('k') | media/formats/mp4/box_definitions.cc » ('j') | media/formats/mpeg/adts_stream_parser.cc » ('J')