media-internals: Differentiate error, info, and debug log messages

media/formats/mpeg/adts_stream_parser.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/formats/mpeg/adts_stream_parser.h"
 
 #include "media/formats/mpeg/adts_constants.h"
 
 namespace media {
 
@@ skipping 51 matching lines @@
            << " version 0x" << version
            << " layer 0x" << layer
            << " profile 0x" << profile
            << " sample_rate_index 0x" << sample_rate_index
            << " channel_layout_index 0x" << channel_layout_index;
 
   const int bytes_read = reader.bits_read() / 8;
   if (sync != 0xfff || layer != 0 || frame_length < bytes_read ||
       sample_rate_index >= kADTSFrequencyTableSize ||
       channel_layout_index >= kADTSChannelLayoutTableSize) {
-    MEDIA_LOG(log_cb()) << "Invalid header data :" << std::hex
-                        << " sync 0x" << sync
-                        << " version 0x" << version
-                        << " layer 0x" << layer
-                        << " sample_rate_index 0x" << sample_rate_index
-                        << " channel_layout_index 0x" << channel_layout_index;
+    MEDIA_LOG(log_cb(), ERROR) << "Invalid header data :" << std::hex

[DaleCurtis, 2015/03/31 00:12:26]

Hmm are these truly errors? They won't break Append() just cause it to skip the
frame.

[wolenetz, 2015/03/31 00:30:11]

You're right; not ERROR in all cases. I'll change to DEBUG.

[wolenetz, 2015/03/31 19:20:22]

Done.

+                               << " sync 0x" << sync
+                               << " version 0x" << version
+                               << " layer 0x" << layer
+                               << " sample_rate_index 0x" << sample_rate_index
+                               << " channel_layout_index 0x"
+                               << channel_layout_index;
     return -1;
   }
 
   if (sample_rate)
     *sample_rate = kADTSFrequencyTable[sample_rate_index];
 
   if (frame_size)
     *frame_size = frame_length;
 
   if (sample_count)
     *sample_count = (num_data_blocks + 1) * kSamplesPerAACFrame;
 
   if (channel_layout)
     *channel_layout = kADTSChannelLayoutTable[channel_layout_index];
 
   if (metadata_frame)
     *metadata_frame = false;
 
   return bytes_read;
 }
 
 }  // namespace media