MacViews: Remove BrowserWindowController dependency from AppController

MacViews: Remove BrowserWindowController dependency from AppController

For mac_views_browser, we want to use AppControllerMac but we don't want
to include BrowserWindowController and friends, to avoid duplicate symbols
and ODR violations.

This patch removes all BrowserWindowController dependencies from AppController
and ConfirmQuitPanelController (which is used by AppController).

BUG=425229
Committed: https://crrev.com/55fd251dd261f24caa80355f03f861b5157518b9
Cr-Commit-Position: refs/heads/master@{#323326}

[Andre, 2015-03-30 22:36:20]

andresantoso@chromium.org changed reviewers:
+ rsesek@chromium.org

[Andre, 2015-03-30 22:40:41]

Robert, PTAL.

[Andre, 2015-03-31 17:31:53]

Also removed dependency from ConfirmQuitPanelController in patchset 2.

[Robert Sesek, 2015-03-31 22:46:35]

https://codereview.chromium.org/1041313003/diff/20001/chrome/browser/app_cont...
File chrome/browser/app_controller_mac.mm (left):

https://codereview.chromium.org/1041313003/diff/20001/chrome/browser/app_cont...
chrome/browser/app_controller_mac.mm:955: [BrowserWindowController
updateSigninItem:item
Could you move this method to AppController instead (since it deals with the
main menu, it makes more sense to be there anyways?)?

https://codereview.chromium.org/1041313003/diff/20001/chrome/browser/app_cont...
File chrome/browser/app_controller_mac.mm (right):

https://codereview.chromium.org/1041313003/diff/20001/chrome/browser/app_cont...
chrome/browser/app_controller_mac.mm:1143:
@selector(commandDispatchUsingKeyModifiers:)]) {
nit: indent +4

[Andre, 2015-03-31 23:09:44]

https://codereview.chromium.org/1041313003/diff/20001/chrome/browser/app_cont...
File chrome/browser/app_controller_mac.mm (left):

https://codereview.chromium.org/1041313003/diff/20001/chrome/browser/app_cont...
chrome/browser/app_controller_mac.mm:955: [BrowserWindowController
updateSigninItem:item
On 2015/03/31 22:46:35, Robert Sesek wrote:
> Could you move this method to AppController instead (since it deals with the
> main menu, it makes more sense to be there anyways?)?

Done.

https://codereview.chromium.org/1041313003/diff/20001/chrome/browser/app_cont...
File chrome/browser/app_controller_mac.mm (right):

https://codereview.chromium.org/1041313003/diff/20001/chrome/browser/app_cont...
chrome/browser/app_controller_mac.mm:1143:
@selector(commandDispatchUsingKeyModifiers:)]) {
On 2015/03/31 22:46:35, Robert Sesek wrote:
> nit: indent +4

Done.

[Robert Sesek, 2015-04-01 15:17:45]

LGTM

https://codereview.chromium.org/1041313003/diff/40001/chrome/browser/app_cont...
File chrome/browser/app_controller_mac.mm (right):

https://codereview.chromium.org/1041313003/diff/40001/chrome/browser/app_cont...
chrome/browser/app_controller_mac.mm:310: NSMenuItem* signinMenuItem =
static_cast<NSMenuItem*>(signinItem);
nit: can use base::mac::ObjCCastStrict<>.

[Robert Sesek, 2015-04-01 15:18:21]

It looks like there's a unittest for the updateSigninItem: method that should be
moved as well.

[Andre, 2015-04-01 20:15:13]

On 2015/04/01 15:18:21, Robert Sesek wrote:
> It looks like there's a unittest for the updateSigninItem: method that should
be
> moved as well.

Oops. Fixed with patchset 4.

[Robert Sesek, 2015-04-01 20:39:56]

LGTM

[Andre, 2015-04-01 21:01:08]

The CQ bit was checked by andresantoso@chromium.org

[commit-bot: I haz the power, 2015-04-01 21:01:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1041313003/60001

[commit-bot: I haz the power, 2015-04-01 21:07:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-01 21:08:27]

Patchset 4 (id:??) landed as
https://crrev.com/55fd251dd261f24caa80355f03f861b5157518b9
Cr-Commit-Position: refs/heads/master@{#323326}