chrome/browser/speech/extension_api/tts_extension_api_platform.h - Issue 10413054: Make ExtensionTtsPlatformImplWin a leaky singleton to avoid a crash in the destructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/extension_api/tts_extension_api_platform.h

Issue 10413054: Make ExtensionTtsPlatformImplWin a leaky singleton to avoid a crash in the destructor. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Add crbug link to comment Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/speech/extension_api/tts_extension_api_platform.h

diff --git a/chrome/browser/speech/extension_api/tts_extension_api_platform.h b/chrome/browser/speech/extension_api/tts_extension_api_platform.h

index 21397c753020819cd8d38b968fcb7526afaa97b8..26bdbae8c34948ee2f8bc600038f5050b7af7a48 100644

--- a/chrome/browser/speech/extension_api/tts_extension_api_platform.h

+++ b/chrome/browser/speech/extension_api/tts_extension_api_platform.h

@@ -53,6 +53,9 @@ class ExtensionTtsPlatformImpl {

protected:

ExtensionTtsPlatformImpl() {}

+ // On some platforms this may be a leaky singleton - do not rely on the

+ // destructor being called! http://crbug.com/122026

virtual ~ExtensionTtsPlatformImpl() {}

std::string error_;

« no previous file with comments | « no previous file | chrome/browser/speech/extension_api/tts_extension_api_win.cc » ('j') | no next file with comments »