Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Issue 104123003: Add a flag for enabling/disabling the navigator content utils (Closed)

Created:
7 years ago by gyuyoung-inactive
Modified:
7 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add a flag for enabling/disabling the navigator content utils As a part of removing ENABLE(NAVIGATOR_CONTENT_UTILS), this cl add a flag for the navigator content utils and enable it except for android. BUG=N/A Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239691

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M content/child/runtime_features.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
gyuyoung-inactive
7 years ago (2013-12-04 09:20:19 UTC) #1
abarth-chromium
I'm not an owner here. You'll have to ask someone else.
7 years ago (2013-12-04 17:11:27 UTC) #2
gyuyoung-inactive
Add jochen and darin. Could you take a look this cl ? BTW, abarth, 91313002 ...
7 years ago (2013-12-05 00:18:34 UTC) #3
jochen (gone - plz use gerrit)
lgtm
7 years ago (2013-12-05 08:57:41 UTC) #4
gyuyoung-inactive
On 2013/12/05 08:57:41, jochen wrote: > lgtm Abarth, could you take a look 91313002 ? ...
7 years ago (2013-12-05 13:24:47 UTC) #5
gyuyoung-inactive
On 2013/12/05 13:24:47, gyuyoung wrote: > On 2013/12/05 08:57:41, jochen wrote: > > lgtm > ...
7 years ago (2013-12-09 11:31:43 UTC) #6
jochen (gone - plz use gerrit)
On 2013/12/09 11:31:43, gyuyoung wrote: > On 2013/12/05 13:24:47, gyuyoung wrote: > > On 2013/12/05 ...
7 years ago (2013-12-09 12:16:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/104123003/1
7 years ago (2013-12-09 12:16:19 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=200497
7 years ago (2013-12-09 12:29:42 UTC) #9
jochen (gone - plz use gerrit)
I guess the blink side changed hasn't yet rolled in. once it has rolled in, ...
7 years ago (2013-12-09 12:32:20 UTC) #10
jam
https://codereview.chromium.org/104123003/diff/1/content/public/common/content_switches.h File content/public/common/content_switches.h (right): https://codereview.chromium.org/104123003/diff/1/content/public/common/content_switches.h#newcode57 content/public/common/content_switches.h:57: extern const char kDisableNavigatorContentUtils[]; nit: note this file is ...
7 years ago (2013-12-09 16:35:56 UTC) #11
gyuyoung-inactive
On 2013/12/09 16:35:56, jam wrote: > https://codereview.chromium.org/104123003/diff/1/content/public/common/content_switches.h > File content/public/common/content_switches.h (right): > > https://codereview.chromium.org/104123003/diff/1/content/public/common/content_switches.h#newcode57 > ...
7 years ago (2013-12-10 00:38:15 UTC) #12
gyuyoung-inactive
On 2013/12/09 12:32:20, jochen wrote: > I guess the blink side changed hasn't yet rolled ...
7 years ago (2013-12-10 00:42:00 UTC) #13
gyuyoung-inactive
On 2013/12/09 12:16:10, jochen wrote: > On 2013/12/09 11:31:43, gyuyoung wrote: > > On 2013/12/05 ...
7 years ago (2013-12-10 00:50:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/104123003/20001
7 years ago (2013-12-10 01:25:32 UTC) #15
gyuyoung-inactive
On 2013/12/10 01:25:32, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years ago (2013-12-10 05:08:10 UTC) #16
commit-bot: I haz the power
7 years ago (2013-12-10 07:13:16 UTC) #17
Message was sent while issue was closed.
Change committed as 239691

Powered by Google App Engine
This is Rietveld 408576698