Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1041183002: SkPDF: remove SK_NO_FLATE & dead code in SkPDFStream (Closed)

Created:
5 years, 8 months ago by hal.canary
Modified:
5 years, 8 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: remove SK_NO_FLATE & dead code in SkPDFStream SkPDFStream copy constructor SkPDFStream Substitute mechanism SkPDFStream::setData(NULL); SkPDFStream SK_NO_FLATE logic BUG=skia:3585 TBR=bsalomon@google.com,reed@google.com Committed: https://skia.googlesource.com/skia/+/af9c85dee116fdc5f32029ac6a4fa7882c6b9a63

Patch Set 1 #

Patch Set 2 : 2015-03-30 (Monday) 12:19:51 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -85 lines) Patch
M include/config/SkUserConfig.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/core/SkFlate.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/core/SkFlate.cpp View 1 2 chunks +0 lines, -6 lines 0 comments Download
M src/pdf/SkPDFStream.h View 3 chunks +0 lines, -18 lines 0 comments Download
M src/pdf/SkPDFStream.cpp View 4 chunks +5 lines, -45 lines 0 comments Download
M tests/DeflateWStream.cpp View 1 2 chunks +0 lines, -3 lines 0 comments Download
M tests/FlateTest.cpp View 1 2 chunks +0 lines, -3 lines 0 comments Download
M tests/PDFPrimitivesTest.cpp View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041183002/1
5 years, 8 months ago (2015-03-30 15:43:52 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-03-30 15:43:52 UTC) #3
hal.canary
ptal
5 years, 8 months ago (2015-03-30 15:44:41 UTC) #5
hal.canary
On 2015/03/30 15:44:41, Hal Canary wrote: > ptal oaky?
5 years, 8 months ago (2015-03-30 22:58:15 UTC) #7
mtklein
lgtm
5 years, 8 months ago (2015-03-30 23:06:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041183002/20001
5 years, 8 months ago (2015-03-31 14:53:32 UTC) #10
commit-bot: I haz the power
Presubmit check for 1041183002-20001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-03-31 14:53:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041183002/20001
5 years, 8 months ago (2015-03-31 15:15:28 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 15:22:06 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/af9c85dee116fdc5f32029ac6a4fa7882c6b9a63

Powered by Google App Engine
This is Rietveld 408576698