Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1041173002: [turbofan] Fix test of %_MathClz32 intrinsic. (Closed)

Created:
5 years, 8 months ago by Michael Starzinger
Modified:
5 years, 8 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix test of %_MathClz32 intrinsic. This test will fail once we optimize top-level code, because the aforementioned intrinsic doesn't perform a NumberToUint32 conversion. R=titzer@chromium.org TEST=mjsunit/asm/math-clz32 Committed: https://crrev.com/6c19c79f596ae6872c7b5b2fe2b31ff4f5c8cb51 Cr-Commit-Position: refs/heads/master@{#27524}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/mjsunit/asm/math-clz32.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
Ben: PTAL. Benedikt: FYI.
5 years, 8 months ago (2015-03-30 14:46:57 UTC) #2
titzer
5 years, 8 months ago (2015-03-30 14:48:43 UTC) #3
titzer
LGTM
5 years, 8 months ago (2015-03-30 14:49:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041173002/1
5 years, 8 months ago (2015-03-30 14:49:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-30 15:10:33 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 15:10:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c19c79f596ae6872c7b5b2fe2b31ff4f5c8cb51
Cr-Commit-Position: refs/heads/master@{#27524}

Powered by Google App Engine
This is Rietveld 408576698