Support multiple occurrences of text in context

lib/src/span_with_context.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library source_span.span_with_context;
 
 import 'location.dart';
 import 'span.dart';
 
 /// A class that describes a segment of source text with additional context.
@@ skipping 11 matching lines @@
   /// [context].
   SourceSpanWithContext(
       SourceLocation start, SourceLocation end, String text, this.context)
       : super(start, end, text) {
     var index = context.indexOf(text);
     if (index == -1) {
       throw new ArgumentError(
           'The context line "$context" must contain "$text".');
     }
 
-    var beginningOfLine = context.lastIndexOf('\n', index) + 1;
-    if (start.column != index - beginningOfLine) {
-      throw new ArgumentError('The span text "$text" must start at '
-          'column ${start.column + 1} in a line within "$context".');
+    // Note: `text` can appear in multiple places within context, but we don't
+    // know which occurrance of `text` is the one in the right location.
+    while (index != -1) {
+      var beginningOfLine = context.lastIndexOf('\n', index) + 1;
+
+      // if the column matches, we are all set with validation.
+      if (start.column == index - beginningOfLine) return;
+
+      index = context.indexOf(text, index + 1);
     }

[nweiz, 2015/03/30 23:45:51]

Shouldn't you also do this logic when constructing the message?

[Siggi Cherem (dart-lang), 2015/03/31 01:07:49]

good point - fixed too.

+
+    // No match was found, means that all occurrences of `text` were not in the
+    // right place.
+    throw new ArgumentError('The span text "$text" must start at '
+        'column ${start.column + 1} in a line within "$context".');
   }
 }