Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1041163004: Add a 'gyp_only' GYP target for the GN migration. (Closed)

Created:
5 years, 8 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@performance_browser_tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a 'gyp_only' GYP target for the GN migration. There are a few targets we build in a GYP build of Chromium that we don't actually need and shouldn't be building. We will track them in a 'gyp_only' target to indicate that they don't need to be ported to GN. TBR=brettw@chromium.org BUG=461019 Committed: https://crrev.com/aa9e60e1e08b558a89d0883cdc807ea48f934492 Cr-Commit-Position: refs/heads/master@{#323170}

Patch Set 1 #

Patch Set 2 : fix nacl_loader entry in gn_all, gyp_remaining #

Patch Set 3 : merge to #323110, clean up #

Patch Set 4 : merge to #323155 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -7 lines) Patch
M build/gn_migration.gypi View 1 2 3 5 chunks +27 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Dirk Pranke
5 years, 8 months ago (2015-03-30 23:20:54 UTC) #1
brettw
lgtm
5 years, 8 months ago (2015-03-31 18:11:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041163004/20001
5 years, 8 months ago (2015-03-31 19:30:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/10409)
5 years, 8 months ago (2015-03-31 19:35:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041163004/60001
5 years, 8 months ago (2015-04-01 00:50:27 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-01 02:43:50 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 02:44:45 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/aa9e60e1e08b558a89d0883cdc807ea48f934492
Cr-Commit-Position: refs/heads/master@{#323170}

Powered by Google App Engine
This is Rietveld 408576698