Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1041163003: Revert of Start all children in their own PID namespace. (Closed)

Created:
5 years, 8 months ago by spang
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Start all children in their own PID namespace. (patchset #14 id:360001 of https://codereview.chromium.org/868233011/) Reason for revert: Appears to cause system lockups on Chrome OS. See crbug.com/471878 Original issue's description: > Start all children in their own PID namespace. > > BUG=460972 > > Committed: https://crrev.com/4557699fbb30704f76c68b906d2656d2e322572c > Cr-Commit-Position: refs/heads/master@{#322660} TBR=jln@chromium.org,mdempsky@chromium.org,rickyz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=460972 Committed: https://crrev.com/591f7ec686f9550fc4332b6cf7c3f0ea0544d558 Cr-Commit-Position: refs/heads/master@{#322891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -343 lines) Patch
M content/common/sandbox_linux/sandbox_linux.h View 2 chunks +0 lines, -8 lines 0 comments Download
M content/common/sandbox_linux/sandbox_linux.cc View 1 chunk +1 line, -6 lines 0 comments Download
M content/zygote/zygote_linux.cc View 5 chunks +4 lines, -40 lines 0 comments Download
M content/zygote/zygote_main_linux.cc View 3 chunks +1 line, -15 lines 0 comments Download
M sandbox/linux/services/credentials.h View 2 chunks +9 lines, -17 lines 0 comments Download
M sandbox/linux/services/credentials.cc View 4 chunks +24 lines, -37 lines 0 comments Download
M sandbox/linux/services/credentials_unittest.cc View 3 chunks +11 lines, -14 lines 0 comments Download
M sandbox/linux/services/namespace_sandbox.h View 3 chunks +0 lines, -36 lines 0 comments Download
M sandbox/linux/services/namespace_sandbox.cc View 4 chunks +0 lines, -76 lines 0 comments Download
M sandbox/linux/services/namespace_sandbox_unittest.cc View 2 chunks +0 lines, -94 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
Created Revert of Start all children in their own PID namespace.
5 years, 8 months ago (2015-03-30 22:07:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041163003/1
5 years, 8 months ago (2015-03-30 22:07:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-30 22:09:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041163003/1
5 years, 8 months ago (2015-03-30 22:09:27 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 22:09:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/591f7ec686f9550fc4332b6cf7c3f0ea0544d558
Cr-Commit-Position: refs/heads/master@{#322891}

Powered by Google App Engine
This is Rietveld 408576698