Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1041163002: [turbofan] smash GapInstruction into Instruction (Closed)

Created:
5 years, 8 months ago by dcarney
Modified:
5 years, 8 months ago
Reviewers:
titzer, Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] smash GapInstruction into Instruction R=titzer@chromium.org BUG= Committed: https://crrev.com/e39750a26e920c8cfef62432710476edf3127d46 Cr-Commit-Position: refs/heads/master@{#27538}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : arm compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+519 lines, -586 lines) Patch
M src/compiler/code-generator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/code-generator.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 1 2 3 4 1 chunk +6 lines, -4 lines 0 comments Download
M src/compiler/instruction.h View 6 chunks +32 lines, -69 lines 0 comments Download
M src/compiler/instruction.cc View 1 2 3 4 5 8 chunks +27 lines, -30 lines 0 comments Download
M src/compiler/jump-threading.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler/move-optimizer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/move-optimizer.cc View 1 2 3 4 5 6 7 chunks +55 lines, -68 lines 0 comments Download
M src/compiler/register-allocator.h View 1 2 3 4 5 6 5 chunks +59 lines, -31 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 4 5 36 chunks +268 lines, -294 lines 0 comments Download
M src/compiler/register-allocator-verifier.cc View 1 2 3 4 5 5 chunks +14 lines, -21 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 1 2 3 4 5 6 7 3 chunks +10 lines, -22 lines 0 comments Download
M test/cctest/compiler/test-jump-threading.cc View 1 2 3 4 2 chunks +11 lines, -6 lines 0 comments Download
M test/unittests/compiler/move-optimizer-unittest.cc View 1 2 3 4 5 6 chunks +20 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dcarney
ptal
5 years, 8 months ago (2015-03-31 12:07:12 UTC) #2
titzer
I like it a lot. This should save a bunch of memory as well. Looping ...
5 years, 8 months ago (2015-03-31 12:23:06 UTC) #4
Jarin
On 2015/03/31 12:23:06, titzer wrote: > I like it a lot. This should save a ...
5 years, 8 months ago (2015-03-31 12:56:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041163002/140001
5 years, 8 months ago (2015-03-31 12:59:17 UTC) #7
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 8 months ago (2015-03-31 13:06:42 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 13:06:54 UTC) #9
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/e39750a26e920c8cfef62432710476edf3127d46
Cr-Commit-Position: refs/heads/master@{#27538}

Powered by Google App Engine
This is Rietveld 408576698