scripts/slave/recipe_modules/webrtc/api.py - Issue 1041133003: WebRTC: Re-enable TSan deadlock detection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/webrtc/api.py

Issue 1041133003: WebRTC: Re-enable TSan deadlock detection. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Removed expectation Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/webrtc/api.py

diff --git a/scripts/slave/recipe_modules/webrtc/api.py b/scripts/slave/recipe_modules/webrtc/api.py

index 155568a70249b1876cf35fd6c0a8a5d58d86f178..b2f3f8dae3229740ad78aeb274d5fe91564e8378 100644

--- a/scripts/slave/recipe_modules/webrtc/api.py

+++ b/scripts/slave/recipe_modules/webrtc/api.py

@@ -321,13 +321,6 @@ class WebRTCApi(recipe_api.RecipeApi):

annotate = None # The parallel script doesn't output gtest format.

flakiness_dash = False

- # TODO(kjellander): Disable deadlock detection for all TSan builders

- # except the one in the client.webrtc.fyi waterfall. Remove when

- # webrtc:4106 is fixed.

- if ('with deadlock detection' not in self.m.properties.get('buildername')

- and self.m.chromium.c.gyp_env.GYP_DEFINES.get('tsan') == 1):

- env['TSAN_OPTIONS'] = 'detect_deadlocks=0'

self.m.chromium.runtest(

test=test, args=args, name=name, annotate=annotate, xvfb=True,

flakiness_dash=flakiness_dash, python_mode=python_mode,