Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1041073002: Trigger clean-up GCs between tests of Speedometer (Closed)

Created:
5 years, 8 months ago by haraken
Modified:
5 years, 8 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Trigger clean-up GCs between tests of Speedometer This CL fixes the regression in Speedometer in oilpan builds. BUG= Committed: https://crrev.com/3f8a241fe8b695f765f6c56ef57e4691f389c4c6 Cr-Commit-Position: refs/heads/master@{#323005}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/perf/benchmarks/speedometer.py View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
haraken
Not yet for review. I confirmed that this CL fixes the regression in Speedometer in ...
5 years, 8 months ago (2015-03-30 03:37:29 UTC) #2
keishi
On 2015/03/30 03:37:29, haraken wrote: > Not yet for review. > > I confirmed that ...
5 years, 8 months ago (2015-03-31 06:40:37 UTC) #3
haraken
On 2015/03/31 06:40:37, keishi wrote: > On 2015/03/30 03:37:29, haraken wrote: > > Not yet ...
5 years, 8 months ago (2015-03-31 06:49:33 UTC) #4
haraken
On 2015/03/31 06:49:33, haraken wrote: > On 2015/03/31 06:40:37, keishi wrote: > > On 2015/03/30 ...
5 years, 8 months ago (2015-03-31 06:50:54 UTC) #5
Yuta Kitamura
LGTM tools/perf has "set noparent" OWNERS file, so my approval isn't sufficient, though.
5 years, 8 months ago (2015-03-31 06:56:25 UTC) #7
peria
LGTM This CL is just for OilpanGC, so my LGTM is enough to commit.
5 years, 8 months ago (2015-03-31 07:00:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041073002/1
5 years, 8 months ago (2015-03-31 08:01:26 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-31 09:59:46 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 10:00:26 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f8a241fe8b695f765f6c56ef57e4691f389c4c6
Cr-Commit-Position: refs/heads/master@{#323005}

Powered by Google App Engine
This is Rietveld 408576698