Oilpan: fix WorkerThreadStartupData finalization handling.

Source/modules/compositorworker/CompositorWorkerGlobalScope.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/compositorworker/CompositorWorkerGlobalScope.h"
 
 #include "bindings/core/v8/SerializedScriptValue.h"
 #include "core/workers/WorkerObjectProxy.h"
 #include "core/workers/WorkerThreadStartupData.h"
 #include "modules/EventTargetModules.h"
 #include "modules/compositorworker/CompositorWorkerThread.h"
 
 namespace blink {
 
-PassRefPtrWillBeRawPtr<CompositorWorkerGlobalScope> CompositorWorkerGlobalScope::create(CompositorWorkerThread* thread, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData> startupData, double timeOrigin)
+PassRefPtrWillBeRawPtr<CompositorWorkerGlobalScope> CompositorWorkerGlobalScope::create(CompositorWorkerThread* thread, PassOwnPtr<WorkerThreadStartupData> startupData, double timeOrigin)
 {
+    // Note: startupData is finalized on return. After the relevant parts has been
+    // passed along to the created 'context'.

[haraken, 2015/03/31 23:29:33]

I'm a bit wondering if we could just pass startupData to the WorkerGlobalScope's
constructor. Then we don't need to pass a lot of things to the constructor.

[sof, 2015/04/01 08:05:10]

It would probably come out tidier that way; let me consider that in a followup.

     RefPtrWillBeRawPtr<CompositorWorkerGlobalScope> context = adoptRefWillBeNoop(new CompositorWorkerGlobalScope(startupData->m_scriptURL, startupData->m_userAgent, thread, timeOrigin, startupData->m_starterOrigin, startupData->m_workerClients.release()));

[haraken, 2015/03/31 23:29:33]

I'm just curious but .release() is needed?

[sof, 2015/04/01 08:05:10]

Not with Oilpan, but otherwise yes -- ownership is transferred to the global
scope. 

     context->applyContentSecurityPolicyFromString(startupData->m_contentSecurityPolicy, startupData->m_contentSecurityPolicyType);
     return context.release();
 }
 
 CompositorWorkerGlobalScope::CompositorWorkerGlobalScope(const KURL& url, const String& userAgent, CompositorWorkerThread* thread, double timeOrigin, const SecurityOrigin* starterOrigin, PassOwnPtrWillBeRawPtr<WorkerClients> workerClients)
     : WorkerGlobalScope(url, userAgent, thread, timeOrigin, starterOrigin, workerClients)
 {
 }
 
 CompositorWorkerGlobalScope::~CompositorWorkerGlobalScope()
@@ skipping 13 matching lines @@
         return;
     thread()->workerObjectProxy().postMessageToWorkerObject(message, channels.release());
 }
 
 CompositorWorkerThread* CompositorWorkerGlobalScope::thread() const
 {
     return static_cast<CompositorWorkerThread*>(WorkerGlobalScope::thread());
 }
 
 } // namespace blink