Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1040863002: Revert "Enable chrome.automation.getDesktop on all aura platforms." (Closed)

Created:
5 years, 9 months ago by scheib
Modified:
5 years, 9 months ago
Reviewers:
CC:
chromium-reviews, dtseng+watch_chromium.org, je_julie(Not used), sadrul, yusukes+watch_chromium.org, plundblad+watch_chromium.org, yukishiino+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, dzhioev+watch_chromium.org, nektar+watch_chromium.org, extensions-reviews_chromium.org, yuzo+watch_chromium.org, nona+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, kalyank, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Enable chrome.automation.getDesktop on all aura platforms." This reverts commit 35b188a996e59c65787207818c7b90d70007f03d. Caused browser_tests AutomationApiTest.DesktopLoadTabs to fail e.g.: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/22541 """ AutomationApiTest.DesktopLoadTabs (run #1): [ RUN ] AutomationApiTest.DesktopLoadTabs Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [25828:25828:0327/163831:INFO:audio_manager_pulse.cc(258)] Failed to connect to the context. Error: Connection refused [25828:25932:0327/163832:WARNING:data_reduction_proxy_config.cc(330)] SPDY proxy OFF at startup [25828:25828:0327/163832:WARNING:password_store_factory.cc(259)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options. [25828:25828:0327/163832:INFO:CONSOLE(0)] "calling getTree() callback", source: chrome-extension://mojndmjfhfgjjicpoiodenhflfmkopil/load_tabs.html (0) [25828:25828:0327/163832:INFO:CONSOLE(0)] "calling getTree() callback", source: chrome-extension://mojndmjfhfgjjicpoiodenhflfmkopil/load_tabs.html (0) [25828:25828:0327/163832:INFO:CONSOLE(0)] "[FAIL] testLoadTabs: uncaught exception: Cannot read property 'firstChild' of undefined: TypeError: Cannot read property 'firstChild' of undefined at testLoadTabs (chrome-extension://mojndmjfhfgjjicpoiodenhflfmkopil/load_tabs.js:28:36) """ NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=Original Patch Had No Bug!?! TBR=dmazzoni@chromium.org, oshima@chromium.org, sky@chromium.org, dtseng@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/49fdb401fce873c6390f2df5bce2deac2921ee93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -910 lines) Patch
M chrome/browser/chromeos/input_method/accessibility.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/automation/automation_apitest.cc View 4 chunks +3 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/automation_internal/automation_internal_api.cc View 5 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2 View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/tools/publish_webstore_extension.py View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/browser/ui/ash/accessibility/automation_manager_ash.h View 4 chunks +14 lines, -18 lines 0 comments Download
A + chrome/browser/ui/ash/accessibility/automation_manager_ash.cc View 5 chunks +29 lines, -41 lines 0 comments Download
A + chrome/browser/ui/ash/accessibility/ax_root_obj_wrapper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/ash/accessibility/ax_root_obj_wrapper.cc View 2 chunks +15 lines, -2 lines 0 comments Download
A + chrome/browser/ui/ash/accessibility/ax_tree_source_ash.h View 3 chunks +9 lines, -8 lines 0 comments Download
A + chrome/browser/ui/ash/accessibility/ax_tree_source_ash.cc View 3 chunks +23 lines, -23 lines 0 comments Download
A + chrome/browser/ui/ash/accessibility/ax_tree_source_ash_unittest.cc View 5 chunks +44 lines, -44 lines 0 comments Download
D chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc View 1 chunk +0 lines, -163 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/ui/aura/accessibility/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/ui/aura/accessibility/automation_manager_aura.h View 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/browser/ui/aura/accessibility/automation_manager_aura.cc View 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/browser/ui/aura/accessibility/ax_root_obj_wrapper.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/ui/aura/accessibility/ax_root_obj_wrapper.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/ui/aura/accessibility/ax_tree_source_aura.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/ui/aura/accessibility/ax_tree_source_aura.cc View 1 chunk +0 lines, -130 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/desktop/common.js View 1 chunk +8 lines, -22 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/desktop/desktop.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/desktop/load_tabs.js View 1 chunk +22 lines, -8 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/desktop/manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/49fdb401fce873c6390f2df5bce2deac2921ee93 Cr-Commit-Position: refs/heads/master@{#322684}
5 years, 9 months ago (2015-03-28 00:21:20 UTC) #1
scheib
5 years, 9 months ago (2015-03-28 00:21:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
49fdb401fce873c6390f2df5bce2deac2921ee93 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698