Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1040833002: Base: Truncate the timeout of WaitableEvent::TimedWait on Windows. (Closed)

Created:
5 years, 8 months ago by rvargas (doing something else)
Modified:
5 years, 8 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Base: Truncate the timeout of WaitableEvent::TimedWait on Windows. The timeout has to be adjusted to milliseconds (the resolution of the underlying call), but it should be truncated instead of extended, because the documentation clearly states that the function can fail in less time than the passed-in timeout, and by definition, the timeout is the maximum time that the caller is willing to block. BUG=none Committed: https://crrev.com/d65edb7b2d228497056e18100c882f7cf7d59c36 Cr-Commit-Position: refs/heads/master@{#323178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M base/synchronization/waitable_event_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rvargas (doing something else)
5 years, 8 months ago (2015-03-30 23:44:45 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
5 years, 8 months ago (2015-03-31 23:42:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040833002/1
5 years, 8 months ago (2015-04-01 03:06:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 04:03:03 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 04:03:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d65edb7b2d228497056e18100c882f7cf7d59c36
Cr-Commit-Position: refs/heads/master@{#323178}

Powered by Google App Engine
This is Rietveld 408576698