Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: content/browser/renderer_host/begin_frame_observer_proxy.h

Issue 1040813002: Revert of Enable BeginFrame scheduling on aura (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_BEGIN_FRAME_OBSERVER_PROXY_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_BEGIN_FRAME_OBSERVER_PROXY_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_BEGIN_FRAME_OBSERVER_PROXY_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_BEGIN_FRAME_OBSERVER_PROXY_H_
7 7
8 #include "content/common/content_export.h" 8 #include "content/common/content_export.h"
9 #include "ui/compositor/compositor.h" 9 #include "ui/compositor/compositor.h"
10 #include "ui/compositor/compositor_observer.h" 10 #include "ui/compositor/compositor_observer.h"
11 11
12 namespace cc { 12 namespace cc {
13 struct BeginFrameArgs; 13 struct BeginFrameArgs;
14 } 14 }
15 15
16 namespace content { 16 namespace content {
17 17
18 // This is the interface from the BeginFrameObserverProxy which manages sending 18 // This is the interface from the BeginFrameObserverProxy which manages sending
19 // BeginFrame messages. 19 // BeginFrame messages.
20 class BeginFrameObserverProxyClient { 20 class BeginFrameObserverProxyClient {
21 public: 21 public:
22 virtual void SendBeginFrame(const cc::BeginFrameArgs& args) = 0; 22 virtual void SendBeginFrame(const cc::BeginFrameArgs& args) = 0;
23 }; 23 };
24 24
25 // This class is used to manage all of the RenderWidgetHostView state and 25 // This class is used to manage all of the RenderWidgetHostView state and
26 // functionality that is associated with BeginFrame message handling. 26 // functionality that is associated with BeginFrame message handling.
27 class CONTENT_EXPORT BeginFrameObserverProxy 27 class CONTENT_EXPORT BeginFrameObserverProxy
28 : public ui::CompositorBeginFrameObserver, 28 : public ui::CompositorBeginFrameObserver {
29 public ui::CompositorObserver {
30 public: 29 public:
31 explicit BeginFrameObserverProxy(BeginFrameObserverProxyClient* client); 30 explicit BeginFrameObserverProxy(BeginFrameObserverProxyClient* client);
32 ~BeginFrameObserverProxy() override; 31 ~BeginFrameObserverProxy() override;
33 32
34 void SetNeedsBeginFrames(bool needs_begin_frames); 33 void SetNeedsBeginFrames(bool needs_begin_frames);
35 34
36 void SetCompositor(ui::Compositor* compositor); 35 void SetCompositor(ui::Compositor* compositor);
37 void ResetCompositor(); 36 void ResetCompositor();
38 37
39 // Overridden from ui::CompositorBeginFrameObserver: 38 // Overridden from ui::CompositorBeginFrameObserver:
40 void OnSendBeginFrame(const cc::BeginFrameArgs& args) override; 39 void OnSendBeginFrame(const cc::BeginFrameArgs& args) override;
41 40
42 // Overridden from ui::CompositorObserver:
43 // TODO(simonhong): Stop overriding ui::CompositorObserver. We need to make
44 // sure that this class should be destroyed before ui::Compositor.
45 void OnCompositingDidCommit(ui::Compositor* compositor) override {}
46 void OnCompositingStarted(ui::Compositor* compositor,
47 base::TimeTicks start_time) override {}
48 void OnCompositingEnded(ui::Compositor* compositor) override {}
49 void OnCompositingAborted(ui::Compositor* compositor) override {}
50 void OnCompositingLockStateChanged(ui::Compositor* compositor) override {}
51 void OnCompositingShuttingDown(ui::Compositor* compositor) override;
52
53 private: 41 private:
54 void StartObservingBeginFrames(); 42 void StartObservingBeginFrames();
55 void StopObservingBeginFrames(); 43 void StopObservingBeginFrames();
56 44
57 // True when RenderWidget needs a BeginFrame message. 45 // True when RenderWidget needs a BeginFrame message.
58 bool needs_begin_frames_; 46 bool needs_begin_frames_;
59 47
60 // Used whether to send begin frame to client or not. When |args| from 48 // Used whether to send begin frame to client or not. When |args| from
61 // Compositor is different from this, send to client. 49 // Compositor is different from this, send to client.
62 cc::BeginFrameArgs last_sent_begin_frame_args_; 50 cc::BeginFrameArgs last_sent_begin_frame_args_;
63 51
64 BeginFrameObserverProxyClient* client_; 52 BeginFrameObserverProxyClient* client_;
65 ui::Compositor* compositor_; 53 ui::Compositor* compositor_;
66 54
67 DISALLOW_COPY_AND_ASSIGN(BeginFrameObserverProxy); 55 DISALLOW_COPY_AND_ASSIGN(BeginFrameObserverProxy);
68 }; 56 };
69 57
70 } // namespace content 58 } // namespace content
71 59
72 #endif // CONTENT_BROWSER_RENDERER_HOST_BEGIN_FRAME_OBSERVER_PROXY_H_ 60 #endif // CONTENT_BROWSER_RENDERER_HOST_BEGIN_FRAME_OBSERVER_PROXY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698