Issue 10408: Uniqueify out sets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10408: Uniqueify out sets. (Closed)

Created:
12 years, 1 month ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Changed out sets in dispatch tables to be unique; now there is only one out set instance with the same elements.

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -56 lines)			Patch
M	src/jsregexp.h	View	3 chunks	+26 lines, -12 lines	0 comments	Download
M	src/jsregexp.cc	View	10 chunks	+45 lines, -25 lines	0 comments	Download
M	src/jsregexp-inl.h	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	test/cctest/test-regexp.cc	View	3 chunks	+22 lines, -6 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

12 years, 1 month ago (2008-11-12 10:48:36 UTC) #2

Greatness!

http://codereview.chromium.org/10408/diff/1/5
File test/cctest/test-regexp.cc (right):

http://codereview.chromium.org/10408/diff/1/5#newcode354
Line 354: // Execute(".*?(?:a[bc]d|e[fg]h)", "xxxabbefd");
That's not right!

Expand Messages | Collapse Messages