Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Unified Diff: chrome/browser/extensions/api/mdns/mdns_apitest.cc

Issue 1040773002: Limit number of service instances passed to onServiceList listeners. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add new mdns.getMaxServiceInstancesPerEvent() function and update unit tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/mdns/mdns_apitest.cc
diff --git a/chrome/browser/extensions/api/mdns/mdns_apitest.cc b/chrome/browser/extensions/api/mdns/mdns_apitest.cc
index 61d10d33828e47d6f593a9f7134883af3610826f..6c587bff5641358bd0332677f7f3c9531420444b 100644
--- a/chrome/browser/extensions/api/mdns/mdns_apitest.cc
+++ b/chrome/browser/extensions/api/mdns/mdns_apitest.cc
@@ -142,3 +142,17 @@ IN_PROC_BROWSER_TEST_F(MDnsAPITest, MAYBE_RegisterMultipleListeners) {
dns_sd_registry_->DispatchMDnsEvent(test_service_type, services);
EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
}
+
+// TODO(justinlin): Win Dbg has a workaround that makes RunExtensionSubtest
+// always return true without actually running the test. Remove when fixed.
+#if defined(OS_WIN) && !defined(NDEBUG)
+#define MAYBE_GetMaxServiceInstancesPerEvent \
+ DISABLED_GetMaxServiceInstancesPerEvent
+#else
+#define MAYBE_GetMaxServiceInstancesPerEvent GetMaxServiceInstancesPerEvent
+#endif
+// Test loading extension and registering multiple listeners.
+IN_PROC_BROWSER_TEST_F(MDnsAPITest, MAYBE_GetMaxServiceInstancesPerEvent) {
+ EXPECT_TRUE(RunExtensionSubtest("mdns/api",
+ "get_max_service_instances.html"));
+}

Powered by Google App Engine
This is Rietveld 408576698