Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: chrome/browser/extensions/api/mdns/mdns_apitest.cc

Issue 1040773002: Limit number of service instances passed to onServiceList listeners. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add testing:: prefix before MakeMatcher to fix windows build Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/mdns/mdns_api_unittest.cc ('k') | chrome/common/extensions/api/mdns.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/mdns/mdns_apitest.cc
diff --git a/chrome/browser/extensions/api/mdns/mdns_apitest.cc b/chrome/browser/extensions/api/mdns/mdns_apitest.cc
index 80f6e8b5b35a002805c90244d378f307466d3c5d..f7b87be9905ccc1a4034e2ba088353669f939d27 100644
--- a/chrome/browser/extensions/api/mdns/mdns_apitest.cc
+++ b/chrome/browser/extensions/api/mdns/mdns_apitest.cc
@@ -165,3 +165,17 @@ IN_PROC_BROWSER_TEST_F(MDnsAPITest, MAYBE_RegisterTooManyListeners) {
EXPECT_TRUE(RunPlatformAppTest("mdns/api-packaged-apps"))
<< message_;
}
+
+// TODO(justinlin): Win Dbg has a workaround that makes RunExtensionSubtest
+// always return true without actually running the test. Remove when fixed.
+#if defined(OS_WIN) && !defined(NDEBUG)
+#define MAYBE_MaxServiceInstancesPerEventConst \
+ DISABLED_MaxServiceInstancesPerEventConst
+#else
+#define MAYBE_MaxServiceInstancesPerEventConst MaxServiceInstancesPerEventConst
+#endif
+// Test loading extension and registering multiple listeners.
+IN_PROC_BROWSER_TEST_F(MDnsAPITest, MAYBE_MaxServiceInstancesPerEventConst) {
+ EXPECT_TRUE(RunExtensionSubtest("mdns/api",
+ "get_max_service_instances.html"));
+}
« no previous file with comments | « chrome/browser/extensions/api/mdns/mdns_api_unittest.cc ('k') | chrome/common/extensions/api/mdns.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698