Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: chrome/browser/extensions/api/mdns/mdns_api.h

Issue 1040773002: Limit number of service instances passed to onServiceList listeners. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change GetValidOnServiceListListeners() signature and mdns browser test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/mdns/mdns_api.h
diff --git a/chrome/browser/extensions/api/mdns/mdns_api.h b/chrome/browser/extensions/api/mdns/mdns_api.h
index f232d3b07b95432a04137b46d5e01da57ec901cf..65e6c6fe8b88b81b1168f634ba7245c6e4e80ecf 100644
--- a/chrome/browser/extensions/api/mdns/mdns_api.h
+++ b/chrome/browser/extensions/api/mdns/mdns_api.h
@@ -13,6 +13,7 @@
#include "chrome/browser/extensions/api/mdns/dns_sd_registry.h"
#include "extensions/browser/browser_context_keyed_api_factory.h"
#include "extensions/browser/event_router.h"
+#include "extensions/browser/extension_function.h"
namespace content {
class BrowserContext;
@@ -67,6 +68,18 @@ class MDnsAPI : public BrowserContextKeyedAPI,
// Update the current list of service types and update the registry.
void UpdateMDnsListeners(const EventListenerInfo& details);
+ // Write a message to the consoles of extensions listening to a given service
+ // type.
+ void WriteToConsole(const std::string& service_type,
+ content::ConsoleMessageLevel level,
+ const std::string& message);
+
+ // Finds all all the valid listeners of the mdns.onServiceList event and
+ // outputs them to |listeners| if |listeners| is non-null. Also outputs the
mark a. foltz 2015/04/06 23:01:43 There is no parameter named |listeners|.
Red Daly 2015/04/07 18:08:14 Done.
+ // corresponding mDNS service types to |service_types| when |service_types| is
+ // non-null.
+ std::set<const EventListener*> GetValidOnServiceListListeners();
mark a. foltz 2015/04/06 23:01:43 This is just used for iteration, return a const_it
Red Daly 2015/04/07 18:08:14 N/A with new interface, unless you think it makes
+
// Ensure methods are only called on UI thread.
base::ThreadChecker thread_checker_;
content::BrowserContext* const browser_context_;
« no previous file with comments | « no previous file | chrome/browser/extensions/api/mdns/mdns_api.cc » ('j') | chrome/browser/extensions/api/mdns/mdns_api.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698