Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1040753003: MIPS64: Fix exception return from regexp CheckStackGuardState(). (Closed)

Created:
5 years, 9 months ago by paul.l...
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix exception return from regexp CheckStackGuardState(). Lack of sign extension on simulator builds gives bad value for RETRY and EXCEPTION codes. TEST=mjsunit/regexp-stack-overflow, regress-crbug-467047 BUG=v8:3992 LOG=n Committed: https://crrev.com/5b760434814ade98f84aef8dd54e8c888f12de15 Cr-Commit-Position: refs/heads/master@{#27553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M src/mips64/regexp-macro-assembler-mips64.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/mips64/regexp-macro-assembler-mips64.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
paul.l...
PTAL, also see the discussion v8:3992.
5 years, 9 months ago (2015-03-28 19:05:54 UTC) #2
dusmil.imgtec
LGTM, Exactly as I have thought the returned value was int32_t, and simulator cannot handle ...
5 years, 8 months ago (2015-03-30 13:09:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040753003/1
5 years, 8 months ago (2015-03-31 18:20:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-31 18:38:58 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 18:39:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b760434814ade98f84aef8dd54e8c888f12de15
Cr-Commit-Position: refs/heads/master@{#27553}

Powered by Google App Engine
This is Rietveld 408576698