Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 1040743002: Remove WebView resource rewriting fallback case. (Closed)

Created:
5 years, 9 months ago by Torne
Modified:
5 years, 9 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebView resource rewriting fallback case. We no longer build with the Android.mk build system, and so we don't need the special case to handle it not renaming resources when the APK package name is renamed. BUG=447666 Committed: https://crrev.com/69c508c08a66af6907160bbbc5bb101e6c6ceceb Cr-Commit-Position: refs/heads/master@{#322594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 1 chunk +3 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Torne
5 years, 9 months ago (2015-03-27 15:44:09 UTC) #2
sgurun-gerrit only
lgtm
5 years, 9 months ago (2015-03-27 15:58:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040743002/1
5 years, 9 months ago (2015-03-27 16:09:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 16:51:15 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 16:51:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69c508c08a66af6907160bbbc5bb101e6c6ceceb
Cr-Commit-Position: refs/heads/master@{#322594}

Powered by Google App Engine
This is Rietveld 408576698