Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: chrome/browser/chrome_browser_main_android.cc

Issue 10407058: Compile in Breakpad by default on Linux (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Change Android code path Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_main_android.cc
diff --git a/chrome/browser/chrome_browser_main_android.cc b/chrome/browser/chrome_browser_main_android.cc
index 0846570df2ef11348d62d61a8cd0f63d0a72ac8a..354a92de3b2b1341d6fc3048dd08e901e2b7b23f 100644
--- a/chrome/browser/chrome_browser_main_android.cc
+++ b/chrome/browser/chrome_browser_main_android.cc
@@ -23,10 +23,20 @@ ChromeBrowserMainPartsAndroid::~ChromeBrowserMainPartsAndroid() {
void ChromeBrowserMainPartsAndroid::PreProfileInit() {
#if defined(USE_LINUX_BREAKPAD)
+#if defined(GOOGLE_CHROME_BUILD)
// TODO(jcivelli): we should not initialize the crash-reporter when it was not
// enabled. Right now if it is disabled we still generate the minidumps but we
// do not upload them.
- InitCrashReporter();
+ bool breakpad_enabled = true;
+#else
+ bool breakpad_enabled = false;
+#endif
+ // Allow Breakpad to be enabled in Chromium builds for testing purposes.
+ if (!breakpad_enabled)
+ breakpad_enabled = getenv(env_vars::kEnableBreakpad) != NULL;
+
+ if (breakpad_enabled)
+ InitCrashReporter();
#endif
ChromeBrowserMainParts::PreProfileInit();

Powered by Google App Engine
This is Rietveld 408576698