Compile in Breakpad by default on Linux

ppapi/native_client/tests/breakpad_crash_test/nacl.scons

 # -*- python -*-
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 
 Import('env')
 
 if env.Bit('host_windows') or env.Bit('host_mac'):
   expected_crash_dumps = 1
 else:
   # We are also checking that crash dumping does not work
   # unexpectedly, since that might indicate that Breakpad was enabled
   # without checking that it works securely.
   expected_crash_dumps = 0
 
 platform_args = []
 if env.Bit('host_windows') and env.Bit('build_x86_64'):
   platform_args.append('--win64')
 
 def GetNexeByName(name):
   return env.File('${STAGING_DIR}/%s${PROGSUFFIX}' %
                   env.ProgramNameForNmf(name))
 
 
 # This tests that crashes in Chromium's browser process successfully
 # produce crash dumps via Breakpad.
-# TODO(mseaborn): Enable this for Linux, too, when Breakpad is
-# compiled into Chromium by default.
-# See http://code.google.com/p/chromium/issues/detail?id=105778
-if env.Bit('host_windows') or env.Bit('host_mac'):
-  node = env.PPAPIBrowserTester(
-      'breakpad_browser_process_crash_test.out',
-      python_tester_script=env.File('crash_dump_tester.py'),
-      browser_flags=['--crash-test'], # Tell the browser process to crash.
-      url='browser_process_crash.html',
-      nmf_names=[],
-      files=[env.File('browser_process_crash.html')],
-      args=platform_args + ['--expect_browser_process_crash',
-                            '--expected_crash_dumps=1',
-                            '--expected_process_type=browser'])
-  env.AddNodeToTestSuite(
-      node, ['chrome_browser_tests'], 'run_breakpad_browser_process_crash_test',
-      # For some strange reason, this test sometimes fails on the
-      # second run (for the SRPC PPAPI proxy) on the Windows 32-bit
-      # and 64-bit buildbots.  The failure modes are that the browser
-      # process hangs, or that a .dmp file is produced with no .txt
-      # file.  Maybe there is a problem with the command line getting
-      # too long?
-      # TODO(mseaborn): Remove this when the "--enable-nacl-srpc-proxy"
-      # option is removed, or investigate and fix.
-      is_broken=(env.PPAPIBrowserTesterIsBroken() or
-                 env.Bit('running_on_valgrind') or
-                 (env.Bit('host_windows') and
-                  '--enable-nacl-srpc-proxy' in
-                      os.environ.get('NACL_BROWSER_FLAGS', ''))))
+node = env.PPAPIBrowserTester(
+    'breakpad_browser_process_crash_test.out',
+    python_tester_script=env.File('crash_dump_tester.py'),
+    browser_flags=['--crash-test'], # Tell the browser process to crash.
+    url='browser_process_crash.html',
+    nmf_names=[],
+    files=[env.File('browser_process_crash.html')],
+    args=platform_args + ['--expect_browser_process_crash',
+                          '--expected_crash_dumps=1',
+                          '--expected_process_type=browser'])
+env.AddNodeToTestSuite(
+    node, ['chrome_browser_tests'], 'run_breakpad_browser_process_crash_test',
+    # For some strange reason, this test sometimes fails on the
+    # second run (for the SRPC PPAPI proxy) on the Windows 32-bit
+    # and 64-bit buildbots.  The failure modes are that the browser
+    # process hangs, or that a .dmp file is produced with no .txt
+    # file.  Maybe there is a problem with the command line getting
+    # too long?
+    # TODO(mseaborn): Remove this when the "--enable-nacl-srpc-proxy"
+    # option is removed, or investigate and fix.
+    is_broken=(env.PPAPIBrowserTesterIsBroken() or
+               env.Bit('running_on_valgrind') or
+               (env.Bit('host_windows') and
+                '--enable-nacl-srpc-proxy' in
+                    os.environ.get('NACL_BROWSER_FLAGS', ''))))
 
 # This crash in trusted code should produce a crash dump.
 crash_test_url = 'trusted_crash_in_startup.html'
 if env.Bit('pnacl_generate_pexe'):
   crash_test_url += '?is_pnacl=true'
 node = env.PPAPIBrowserTester(
     'breakpad_trusted_crash_in_startup_test.out',
     python_tester_script=env.File('crash_dump_tester.py'),
     url=crash_test_url,
     nmf_names=['crash_test'],
@@ skipping 31 matching lines @@
     python_tester_script=env.File('crash_dump_tester.py'),
     url='untrusted_crash.html',
     nmf_names=['crash_test'],
     files=[GetNexeByName('crash_test'),
            env.File('untrusted_crash.html')],
     args=platform_args + ['--expected_crash_dumps=0'])
 env.AddNodeToTestSuite(
     node, ['chrome_browser_tests'], 'run_breakpad_untrusted_crash_test',
     is_broken=env.PPAPIBrowserTesterIsBroken() or
                env.Bit('running_on_valgrind'))