Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: src/arm/full-codegen-arm.cc

Issue 1040703003: Fix variable decl register collision on ARM. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address review comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-455207.js » ('j') | test/mjsunit/regress/regress-455207.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm/full-codegen-arm.cc
diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc
index 0bcb6a79ccd30154943cb7e363ca9fca50f3de6b..a067edc84807aacb70ef7751f748df0611cbcfb8 100644
--- a/src/arm/full-codegen-arm.cc
+++ b/src/arm/full-codegen-arm.cc
@@ -864,8 +864,8 @@ void FullCodeGenerator::VisitVariableDeclaration(
case Variable::LOCAL:
if (hole_init) {
Comment cmnt(masm_, "[ VariableDeclaration");
- __ LoadRoot(ip, Heap::kTheHoleValueRootIndex);
- __ str(ip, StackOperand(variable));
+ __ LoadRoot(r0, Heap::kTheHoleValueRootIndex);
+ __ str(r0, StackOperand(variable));
}
break;
@@ -873,8 +873,8 @@ void FullCodeGenerator::VisitVariableDeclaration(
if (hole_init) {
Comment cmnt(masm_, "[ VariableDeclaration");
EmitDebugCheckDeclarationContext(variable);
- __ LoadRoot(ip, Heap::kTheHoleValueRootIndex);
- __ str(ip, ContextOperand(cp, variable->index()));
+ __ LoadRoot(r0, Heap::kTheHoleValueRootIndex);
+ __ str(r0, ContextOperand(cp, variable->index()));
// No write barrier since the_hole_value is in old space.
PrepareForBailoutForId(proxy->id(), NO_REGISTERS);
}
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-455207.js » ('j') | test/mjsunit/regress/regress-455207.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698