Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1040653003: Remove support for jarjar-ing layout.xml files. (Closed)

Created:
5 years, 9 months ago by Torne
Modified:
5 years, 8 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, jbudorick+watch_chromium.org, android-webview-reviews_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for jarjar-ing layout.xml files. Now that android_webview_build is being removed we no longer need support for jarjar-ing layout.xml files. Delete the tools used to do this, as well as the jarjar configuration for android_webview_build. BUG=440794 Committed: https://crrev.com/15040fcb70a124db6a7886677d0c78cb7624da8a Cr-Commit-Position: refs/heads/master@{#322860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -226 lines) Patch
M android_webview/android_webview.gyp View 1 chunk +0 lines, -46 lines 0 comments Download
D android_webview/build/jarjar-rules.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D android_webview/build/jarjar_resources.gypi View 1 chunk +0 lines, -50 lines 0 comments Download
D build/android/gyp/jarjar_resources.py View 1 chunk +0 lines, -121 lines 0 comments Download
M build/common.gypi View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Torne
5 years, 9 months ago (2015-03-27 12:04:17 UTC) #2
cjhopman
lgtm
5 years, 8 months ago (2015-03-30 18:16:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040653003/1
5 years, 8 months ago (2015-03-30 19:37:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-30 20:46:44 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 20:47:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15040fcb70a124db6a7886677d0c78cb7624da8a
Cr-Commit-Position: refs/heads/master@{#322860}

Powered by Google App Engine
This is Rietveld 408576698