Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: src/x64/macro-assembler-x64.cc

Issue 1040603002: [x64] Introduce BMI instructions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: clear TODOs of MacroAssembler::Lzcntl Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/x64/macro-assembler-x64.cc
diff --git a/src/x64/macro-assembler-x64.cc b/src/x64/macro-assembler-x64.cc
index 65b65a36222637a7fba42ec9db03062f2c7f9434..42f083554e3dc4b0d7d423a50ccddb65ed71b7fc 100644
--- a/src/x64/macro-assembler-x64.cc
+++ b/src/x64/macro-assembler-x64.cc
@@ -2885,28 +2885,6 @@ void MacroAssembler::Pinsrd(XMMRegister dst, const Operand& src, int8_t imm8) {
}
-void MacroAssembler::Lzcntl(Register dst, Register src) {
- // TODO(intel): Add support for LZCNT (BMI1/ABM).
Benedikt Meurer 2015/04/08 05:45:41 Keep these functions, because not all machines wil
- Label not_zero_src;
- bsrl(dst, src);
- j(not_zero, &not_zero_src, Label::kNear);
- Set(dst, 63); // 63^31 == 32
- bind(&not_zero_src);
- xorl(dst, Immediate(31)); // for x in [0..31], 31^x == 31 - x
-}
-
-
-void MacroAssembler::Lzcntl(Register dst, const Operand& src) {
- // TODO(intel): Add support for LZCNT (BMI1/ABM).
- Label not_zero_src;
- bsrl(dst, src);
- j(not_zero, &not_zero_src, Label::kNear);
- Set(dst, 63); // 63^31 == 32
- bind(&not_zero_src);
- xorl(dst, Immediate(31)); // for x in [0..31], 31^x == 31 - x
-}
-
-
void MacroAssembler::Pushad() {
Push(rax);
Push(rcx);

Powered by Google App Engine
This is Rietveld 408576698