src/compiler/x64/code-generator-x64.cc - Issue 1040603002: [x64] Introduce BMI instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/x64/code-generator-x64.cc

Issue 1040603002: [x64] Introduce BMI instructions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: clear TODOs of MacroAssembler::Lzcntl Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/x64/code-generator-x64.cc

diff --git a/src/compiler/x64/code-generator-x64.cc b/src/compiler/x64/code-generator-x64.cc

index fee2702332d463a4f724043d00c23b0cb0084bcd..da632deada3a41ec2c28f0c8ed1bb3ca29a1d67e 100644

--- a/src/compiler/x64/code-generator-x64.cc

+++ b/src/compiler/x64/code-generator-x64.cc

@@ -706,9 +706,9 @@ void CodeGenerator::AssembleArchInstruction(Instruction* instr) {

break;

case kX64Lzcnt32:

if (instr->InputAt(0)->IsRegister()) {

- __ Lzcntl(i.OutputRegister(), i.InputRegister(0));

+ __ lzcntl(i.OutputRegister(), i.InputRegister(0));

Benedikt Meurer 2015/04/08 05:45:41 Keep the macro assembler version here, because we

} else {

- __ Lzcntl(i.OutputRegister(), i.InputOperand(0));

+ __ lzcntl(i.OutputRegister(), i.InputOperand(0));

Benedikt Meurer 2015/04/08 05:45:41 Same here.

}

break;

case kSSEFloat32Cmp: