Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1040543002: clean up GN targets that are already migrated, add pepper_hash_for_uma. (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 9 months ago
Reviewers:
tfarina, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clean up GN targets that are already migrated, add pepper_hash_for_uma. This updates the gn_all and gyp_remaining targets to reflect the current status. R=tfarina@chromium.org, brettw@chromium.org BUG=461019 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/c09ccaa95ba1a2212f27fd86cd2650526a82a9ea Cr-Commit-Position: refs/heads/master@{#322654}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix components_perftests conditions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -64 lines) Patch
M BUILD.gn View 1 3 chunks +3 lines, -7 lines 0 comments Download
M build/gn_migration.gypi View 8 chunks +15 lines, -56 lines 0 comments Download
M ppapi/BUILD.gn View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
Dirk Pranke
5 years, 9 months ago (2015-03-27 03:09:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040543002/1
5 years, 9 months ago (2015-03-27 03:09:57 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-27 03:09:59 UTC) #6
brettw
lgtm
5 years, 9 months ago (2015-03-27 04:51:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040543002/1
5 years, 9 months ago (2015-03-27 04:51:54 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_dbg on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_dbg/builds/241)
5 years, 9 months ago (2015-03-27 04:55:04 UTC) #11
tfarina
lgtm https://codereview.chromium.org/1040543002/diff/1/build/gn_migration.gypi File build/gn_migration.gypi (right): https://codereview.chromium.org/1040543002/diff/1/build/gn_migration.gypi#newcode419 build/gn_migration.gypi:419: '../gpu/gles2_conform_support/gles2_conform_support.gyp:gles2_conform_support', We seem to have this ported as ...
5 years, 9 months ago (2015-03-27 13:40:35 UTC) #12
tfarina
https://codereview.chromium.org/1040543002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1040543002/diff/1/BUILD.gn#newcode48 BUILD.gn:48: "//components:components_perftests", this is behind is_linux && !is_chromeos, hence the ...
5 years, 9 months ago (2015-03-27 13:42:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040543002/20001
5 years, 9 months ago (2015-03-27 20:20:53 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-27 22:00:47 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 22:01:19 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c09ccaa95ba1a2212f27fd86cd2650526a82a9ea
Cr-Commit-Position: refs/heads/master@{#322654}

Powered by Google App Engine
This is Rietveld 408576698