Autofill OSX: Do not show storage footer when !CanStoreLocally().

Autofill OSX: Do not show storage footer when !CanStoreLocally().

Do not create or show the "Keep this card locally" checkbox footer
when !CanStoreLocally().

BUG=448572
Committed: https://crrev.com/ead8369698d50e47c077245684f6a851cc7eda58
Cr-Commit-Position: refs/heads/master@{#322523}

[bondd, 2015-03-27 00:20:52]

bondd@chromium.org changed reviewers:
+ estade@chromium.org, groby@chromium.org

[bondd, 2015-03-27 00:20:52]

bondd@chromium.org changed required reviewers:
+ groby@chromium.org

[bondd, 2015-03-27 00:20:53]

The logic here is pretty simple but I have a couple of style questions.

https://codereview.chromium.org/1040513002/diff/1/chrome/browser/ui/cocoa/aut...
File chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm (right):

https://codereview.chromium.org/1040513002/diff/1/chrome/browser/ui/cocoa/aut...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:265:
[storageCheckbox_ state] == NSOnState);
storageCheckbox_ can be nil. Apple docs indicate that NSOnState can be assumed
to be non-zero, so this line works as is.
Alternatively:
storageCheckbox_ ? [storageCheckbox_ state] == NSOnState : false

https://codereview.chromium.org/1040513002/diff/1/chrome/browser/ui/cocoa/aut...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:433: if
(controller->CanStoreLocally()) {
CanStoreLocally() check can either go here, or at the top of
-createStorageViewWithController: and return empty scoped_nsobject. I prefer it
here because then -createStorageViewWithController: always does what it says
it's going to do.

[groby-ooo-7-16, 2015-03-27 00:53:18]

https://codereview.chromium.org/1040513002/diff/1/chrome/browser/ui/cocoa/aut...
File chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm (right):

https://codereview.chromium.org/1040513002/diff/1/chrome/browser/ui/cocoa/aut...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:265:
[storageCheckbox_ state] == NSOnState);
On 2015/03/27 00:20:52, bondd wrote:
> storageCheckbox_ can be nil. Apple docs indicate that NSOnState can be assumed
> to be non-zero, so this line works as is.
> Alternatively:
> storageCheckbox_ ? [storageCheckbox_ state] == NSOnState : false

sgtm

https://codereview.chromium.org/1040513002/diff/1/chrome/browser/ui/cocoa/aut...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:433: if
(controller->CanStoreLocally()) {
On 2015/03/27 00:20:52, bondd wrote:
> CanStoreLocally() check can either go here, or at the top of
> -createStorageViewWithController: and return empty scoped_nsobject. I prefer
it
> here because then -createStorageViewWithController: always does what it says
> it's going to do.

sgtm

https://codereview.chromium.org/1040513002/diff/1/chrome/browser/ui/cocoa/aut...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:434:
storageView_ = [self createStorageViewWithController:controller];
storageView_.reset()?

[bondd, 2015-03-27 01:09:38]

No code changes just a question.

https://codereview.chromium.org/1040513002/diff/1/chrome/browser/ui/cocoa/aut...
File chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm (right):

https://codereview.chromium.org/1040513002/diff/1/chrome/browser/ui/cocoa/aut...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:434:
storageView_ = [self createStorageViewWithController:controller];
On 2015/03/27 00:53:17, groby wrote:
> storageView_.reset()?

Sorry, could you please clarify what you mean here? Call storageView_.reset()
when !CanStoreLocally()? Something else?

[groby-ooo-7-16, 2015-03-27 01:36:07]

https://codereview.chromium.org/1040513002/diff/1/chrome/browser/ui/cocoa/aut...
File chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm (right):

https://codereview.chromium.org/1040513002/diff/1/chrome/browser/ui/cocoa/aut...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:434:
storageView_ = [self createStorageViewWithController:controller];
On 2015/03/27 01:09:38, bondd wrote:
> On 2015/03/27 00:53:17, groby wrote:
> > storageView_.reset()?
> 
> Sorry, could you please clarify what you mean here? Call storageView_.reset()
> when !CanStoreLocally()? Something else?

I assumed createStorage... returns a pointer, and suggested reset. Just saw that
it returns a scoped_nsobject, so please ignore

[groby-ooo-7-16, 2015-03-27 02:06:02]

The CQ bit was checked by groby@chromium.org

[groby-ooo-7-16, 2015-03-27 02:06:03]

lgtm

[commit-bot: I haz the power, 2015-03-27 02:06:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1040513002/1

[commit-bot: I haz the power, 2015-03-27 03:06:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-27 03:07:12]

Patchset 1 (id:??) landed as
https://crrev.com/ead8369698d50e47c077245684f6a851cc7eda58
Cr-Commit-Position: refs/heads/master@{#322523}