Formalizes support for '-' in command names.

Formalizes support for '-' in command names.

This officially drops support for '_' in command names, which is ugly as hell.
'_' was very rarely used so it shouldn't affect too much users.

Refactor the code to be more readable.

R=stip@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294660

[M-A Ruel, 2015-03-30 17:46:38]

I used cmd_name for variables that holds the actual command name and name_asked
for user supplied name.

[Cory Massaro, 2015-03-30 19:24:49]

On 2015/03/30 17:46:38, M-A Ruel wrote:
> I used cmd_name for variables that holds the actual command name and
name_asked
> for user supplied name.

Nice! Looks right to me, but I don't think I have L*G_T\M abilities.

[M-A Ruel, 2015-03-31 14:38:08]

Robbie, you can review this now.

[M-A Ruel, 2015-04-02 18:57:53]

maruel@chromium.org changed reviewers:
+ stip@chromium.org
- iannucci@chromium.org

[M-A Ruel, 2015-04-02 18:58:00]

-> stip

[ghost stip (do not use), 2015-04-02 19:16:23]

lgtm

[M-A Ruel, 2015-04-02 19:19:10]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2015-04-02 19:19:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1040503003/1

[commit-bot: I haz the power, 2015-04-02 19:23:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-02 19:23:03]

Presubmit check for 1040503003-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/gclient_smoketest.py (48.08s) failed
Ffatal: reference is not a tree: b5659367e7a1ece291236dc0c164e452db908105
EE...F..........................................
======================================================================
ERROR: testBlinkDEPSChangeUsingGit (__main__.BlinkDEPSTransitionSmokeTest)
Like testBlinkDEPSChangeUsingGclient, but move the main project using
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1630, in testBlinkDEPSChangeUsingGit
    cwd=self.checkout_path)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
484, in check_call
    check_call_out(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
478, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git checkout -q
b5659367e7a1ece291236dc0c164e452db908105 returned non-zero exit status 128 in
/tmp/trialJjS4Hu/__main__.BlinkDEPSTransitionSmokeTest.testBlinkDEPSChangeUsingGit/src

======================================================================
ERROR: testBlinkLocalBranchesArePreserved
(__main__.BlinkDEPSTransitionSmokeTest)
Checks that the state of local git branches are effectively preserved
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1656, in
testBlinkLocalBranchesArePreserved
    self.CheckStatusPreMergePoint()
  File "tests/gclient_smoketest.py", line 1558, in CheckStatusPreMergePoint
    self.blink), self.blink_git_url)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/scm.py", line
121, in Capture
    cwd=cwd, stderr=subprocess2.PIPE, env=env, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
515, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
475, in check_call_out
    out, returncode = communicate(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
449, in communicate
    proc = Popen(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
253, in __init__
    % (str(e), kwargs.get('cwd'), args[0]))
OSError: Execution failed with error: [Errno 2] No such file or directory:
'/tmp/trialJjS4Hu/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit'.
Check that
/tmp/trialJjS4Hu/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit
or git exist and have execution permission.

======================================================================
FAIL: testBlinkDEPSChangeUsingGclient (__main__.BlinkDEPSTransitionSmokeTest)
Checks that {src,blink} repos are consistent when syncing going back and
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1601, in
testBlinkDEPSChangeUsingGclient
    self.assertEqual(res[2], 0, 'DEPS change sync failed.')
AssertionError: DEPS change sync failed.

======================================================================
FAIL: testNotConfigured (__main__.GClientSmoke)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 198, in testNotConfigured
    self.check(res, self.gclient(['update']))
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 906, in check
    self.checkString(expected[0], results[0])
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 902, in checkString
    self.assertEquals(expected, result, msg)
AssertionError: '' != "Usage: gclient.py <command> [options]\n\nMeta checkout
manager supporting both Subversion and GIT.\n\nCommands are:\n  \x1b[32mcleanup
\x1b[39m cleans up all working copies\n  \x1b[32mconfig  \x1b[39m creates a
.gclient file in the current directory\n  \x1b[32mdiff    \x1b[39m displays
local diff for every dependencies\n  \x1b[32mfetch   \x1b[39m fetches upstream
commits for all modules\n  \x1b[32mgrep    \x1b[39m greps through git repos
managed by gclient\n  \x1b[32mhelp    \x1b[39m prints list of commands or help
for a specific command\n  \x1b[32mhookinfo\x1b[39m outputs the hooks that would
be run by `gclient runhooks`\n  \x1b[32mpack    \x1b[39m generates a patch which
can be applied at the root of the tree\n  \x1b[32mrecurse \x1b[39m operates
[command args ...] on all the dependencies\n  \x1b[32mrevert  \x1b[39m reverts
all modifications in every dependencies\n  \x1b[32mrevinfo \x1b[39m outputs
revision info mapping for the client and its dependencies\n 
\x1b[32mrunhooks\x1b[39m runs hooks for files that have been modified in the
local working copy\n  \x1b[32mstatus  \x1b[39m shows modification status for
every dependencies\n  \x1b[32msync    \x1b[39m checkout/update all modules\n 
\x1b[32mverify  \x1b[39m verifies the DEPS file deps are only from
allowed_hosts\n\nOptions:\n  --version             show program's version number
and exit\n  -h, --help            show this help message and exit\n  -j JOBS,
--jobs=JOBS  Specify how many SCM commands can run in parallel;\n               
        defaults to 16 on this machine\n  -v, --verbose         Produces
additional output for diagnostics. Can be\n                        used up to
three times for more logging info.\n  --gclientfile=CONFIG_FILENAME\n           
            Specify an alternate .gclient file\n  --spec=SPEC           create a
gclient file containing the provided string.\n                        Due to
Cygwin/Python brokenness, it can't contain any\n                       
newlines.\n  --no-nag-max          Ignored for backwards compatibility.\n"

----------------------------------------------------------------------
Ran 49 tests in 47.877s

FAILED (failures=2, errors=2)
Usage: gclient.py <command> [options]

Meta checkout manager supporting both Subversion and GIT.

Commands are:
  cleanup  cleans up all working copies
  config   creates a .gclient file in the current directory
  diff     displays local diff for every dependencies
  fetch    fetches upstream commits for all modules
  grep     greps through git repos managed by gclient
  help     prints list of commands or help for a specific command
  hookinfo outputs the hooks that would be run by `gclient runhooks`
  pack     generates a patch which can be applied at the root of the
tree
  recurse  operates [command args ...] on all the dependencies
  revert   reverts all modifications in every dependencies
  revinfo  outputs revision info mapping for the client and its
dependencies
  runhooks runs hooks for files that have been modified in the local
working copy
  status   shows modification status for every dependencies
  sync     checkout/update all modules
  verify   verifies the DEPS file deps are only from allowed_hosts

Options:
  --version             show program's version number and exit
  -h, --help            show this help message and exit
  -j JOBS, --jobs=JOBS  Specify how many SCM commands can run in parallel;
                        defaults to 16 on this machine
  -v, --verbose         Produces additional output for diagnostics. Can be
                        used up to three times for more logging info.
  --gclientfile=CONFIG_FILENAME
                        Specify an alternate .gclient file
  --spec=SPEC           create a gclient file containing the provided string.
                        Due to Cygwin/Python brokenness, it can't contain any
                        newlines.
  --no-nag-max          Ignored for backwards compatibility.



Presubmit checks took 185.1s to calculate.

[M-A Ruel, 2015-04-02 19:24:31]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2015-04-02 19:25:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1040503003/1

[commit-bot: I haz the power, 2015-04-02 19:28:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-02 19:28:18]

Presubmit check for 1040503003-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/gclient_smoketest.py (48.09s) failed
......F..........................................
======================================================================
FAIL: testNotConfigured (__main__.GClientSmoke)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 198, in testNotConfigured
    self.check(res, self.gclient(['update']))
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 906, in check
    self.checkString(expected[0], results[0])
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 902, in checkString
    self.assertEquals(expected, result, msg)
AssertionError: '' != "Usage: gclient.py <command> [options]\n\nMeta checkout
manager supporting both Subversion and GIT.\n\nCommands are:\n  \x1b[32mcleanup
\x1b[39m cleans up all working copies\n  \x1b[32mconfig  \x1b[39m creates a
.gclient file in the current directory\n  \x1b[32mdiff    \x1b[39m displays
local diff for every dependencies\n  \x1b[32mfetch   \x1b[39m fetches upstream
commits for all modules\n  \x1b[32mgrep    \x1b[39m greps through git repos
managed by gclient\n  \x1b[32mhelp    \x1b[39m prints list of commands or help
for a specific command\n  \x1b[32mhookinfo\x1b[39m outputs the hooks that would
be run by `gclient runhooks`\n  \x1b[32mpack    \x1b[39m generates a patch which
can be applied at the root of the tree\n  \x1b[32mrecurse \x1b[39m operates
[command args ...] on all the dependencies\n  \x1b[32mrevert  \x1b[39m reverts
all modifications in every dependencies\n  \x1b[32mrevinfo \x1b[39m outputs
revision info mapping for the client and its dependencies\n 
\x1b[32mrunhooks\x1b[39m runs hooks for files that have been modified in the
local working copy\n  \x1b[32mstatus  \x1b[39m shows modification status for
every dependencies\n  \x1b[32msync    \x1b[39m checkout/update all modules\n 
\x1b[32mverify  \x1b[39m verifies the DEPS file deps are only from
allowed_hosts\n\nOptions:\n  --version             show program's version number
and exit\n  -h, --help            show this help message and exit\n  -j JOBS,
--jobs=JOBS  Specify how many SCM commands can run in parallel;\n               
        defaults to 16 on this machine\n  -v, --verbose         Produces
additional output for diagnostics. Can be\n                        used up to
three times for more logging info.\n  --gclientfile=CONFIG_FILENAME\n           
            Specify an alternate .gclient file\n  --spec=SPEC           create a
gclient file containing the provided string.\n                        Due to
Cygwin/Python brokenness, it can't contain any\n                       
newlines.\n  --no-nag-max          Ignored for backwards compatibility.\n"

----------------------------------------------------------------------
Ran 49 tests in 47.895s

FAILED (failures=1)
Usage: gclient.py <command> [options]

Meta checkout manager supporting both Subversion and GIT.

Commands are:
  cleanup  cleans up all working copies
  config   creates a .gclient file in the current directory
  diff     displays local diff for every dependencies
  fetch    fetches upstream commits for all modules
  grep     greps through git repos managed by gclient
  help     prints list of commands or help for a specific command
  hookinfo outputs the hooks that would be run by `gclient runhooks`
  pack     generates a patch which can be applied at the root of the
tree
  recurse  operates [command args ...] on all the dependencies
  revert   reverts all modifications in every dependencies
  revinfo  outputs revision info mapping for the client and its
dependencies
  runhooks runs hooks for files that have been modified in the local
working copy
  status   shows modification status for every dependencies
  sync     checkout/update all modules
  verify   verifies the DEPS file deps are only from allowed_hosts

Options:
  --version             show program's version number and exit
  -h, --help            show this help message and exit
  -j JOBS, --jobs=JOBS  Specify how many SCM commands can run in parallel;
                        defaults to 16 on this machine
  -v, --verbose         Produces additional output for diagnostics. Can be
                        used up to three times for more logging info.
  --gclientfile=CONFIG_FILENAME
                        Specify an alternate .gclient file
  --spec=SPEC           create a gclient file containing the provided string.
                        Due to Cygwin/Python brokenness, it can't contain any
                        newlines.
  --no-nag-max          Ignored for backwards compatibility.



Presubmit checks took 170.2s to calculate.

[M-A Ruel, 2015-04-02 19:53:04]

This was an actual regression for command aliases, fixed.

[M-A Ruel, 2015-04-02 19:53:08]

The CQ bit was checked by maruel@chromium.org

[M-A Ruel, 2015-04-02 19:53:08]

The patchset sent to the CQ was uploaded after l-g-t-m from stip@chromium.org
Link to the patchset: https://codereview.chromium.org/1040503003/#ps20001
(title: "Fix regression in new code which broke aliases")

[commit-bot: I haz the power, 2015-04-02 19:53:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1040503003/20001

[commit-bot: I haz the power, 2015-04-02 19:57:00]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294660

[chromium-reviews, 2015-04-03 00:22:32]

Did this make it into the LUCI repo, as well? I've rebased onto it but my
parsers still want underscores.

On Thu, Apr 2, 2015 at 12:57 PM, <commit-bot@chromium.org> wrote:

> Committed patchset #2 (id:20001) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=294660
>
> https://codereview.chromium.org/1040503003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[M-A Ruel, 2015-04-03 00:57:44]

On 2015/04/03 00:22:32, chromium-reviews wrote:
> Did this make it into the LUCI repo, as well? I've rebased onto it but my
> parsers still want underscores.

It was https://codereview.chromium.org/1052993003.