Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1040493003: Autofill OSX: Hide storage checkbox and tooltip while verifying. (Closed)

Created:
5 years, 9 months ago by bondd
Modified:
5 years, 9 months ago
CC:
chromium-reviews, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cup_14_disable_after_error_02
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill OSX: Hide storage checkbox and tooltip while verifying. Hide "Keep this card locally" checkbox and tooltip while verifying card. Space in the dialog is still reserved for the footer; it's just empty. BUG=448572 Committed: https://crrev.com/52c422afc392b85a3d6287cd5b9b551d8126770a Cr-Commit-Position: refs/heads/master@{#322532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bondd
This one-liner doesn't overlap at all with https://codereview.chromium.org/1040513002/ so I'm making it a separate CL.
5 years, 9 months ago (2015-03-27 00:45:55 UTC) #3
groby-ooo-7-16
LGTM - but if something like this can be rolled into a related CL, I ...
5 years, 9 months ago (2015-03-27 00:54:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040493003/1
5 years, 9 months ago (2015-03-27 02:12:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 04:58:20 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 04:59:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52c422afc392b85a3d6287cd5b9b551d8126770a
Cr-Commit-Position: refs/heads/master@{#322532}

Powered by Google App Engine
This is Rietveld 408576698