Added --(de)activate-update options

Added --(de)activate-update options

These options have been added to the 'git cl config' subcommand.
--deactivate-update tells git cl not to update the values inside
.git/config from the codereview.settings file. --activate-update does
the opposite.

This is designed for testing/development purposes only, for example, to
be able to change the rietveld URL.

BUG=327901
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=242943

[pgervais, 2013-12-16 19:06:46]

A small fix to make 'git cl config' usable. 
In the previous state, each invocation of 'git cl' would wipe everything in the
[rietveld] section of .git/config, with values from the codereview.settings
file. This CL adds a 'noautoupdate' key to prevent this auto update, allowing
modifications done with 'git cl config' to stay in place. 

I used a git config parameter because it has to be local, and cannot be stored
in a file that could be tracked by git (that would prevent 'git cl upload' from
working since it requires a clean tree).

Comments and criticisms welcome.

[ghost stip (do not use), 2013-12-16 19:20:20]

style nits, will review in earnest in a bit

https://codereview.chromium.org/104043008/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/104043008/diff/1/git_cl.py#newcode1092
git_cl.py:1092: '.git/config')
align '.git with 'activate

https://codereview.chromium.org/104043008/diff/1/git_cl.py#newcode1095
git_cl.py:1095: '.git/config')
same

[iannucci, 2013-12-17 00:21:38]

https://codereview.chromium.org/104043008/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/104043008/diff/1/git_cl.py#newcode271
git_cl.py:271: ).strip().lower()
polarity should reverse to 'autoupdate'

https://codereview.chromium.org/104043008/diff/1/git_cl.py#newcode274
git_cl.py:274: return
then this block can go away.

https://codereview.chromium.org/104043008/diff/1/git_cl.py#newcode277
git_cl.py:277: if cr_settings_file:
if autoupdate and cr_settings_file:

https://codereview.chromium.org/104043008/diff/1/git_cl.py#newcode1093
git_cl.py:1093: parser.add_option('--deactivate-update', action='store_true',
Hm... I think these should both have dest='activate_autoupdate', and this one
should be store_false. You can tell if the user passed in a value by doing an
identity comparison with None. i.e. `if activate_autoupdate is not None:`

https://codereview.chromium.org/104043008/diff/1/git_cl.py#newcode1099
git_cl.py:1099: RunGit(['config', 'rietveld.noautoupdate', 'true'])
option should be rietveld.autoupdate

[pgervais, 2013-12-18 00:02:37]

I hopefully addressed all the concerns in the last patchset.

[ghost stip (do not use), 2014-01-03 20:40:21]

lgtm

https://chromiumcodereview.appspot.com/104043008/diff/20001/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/104043008/diff/20001/git_cl.py#newcode272
git_cl.py:272: autoupdate = RunGit(['config', 'rietveld.autoupdate'],
error_ok=True
style nit: put error_ok on the next line (+4)

   RunGit([....],
       error_ok=True).strip().lower()

https://chromiumcodereview.appspot.com/104043008/diff/20001/tests/git_cl_test.py
File tests/git_cl_test.py (right):

https://chromiumcodereview.appspot.com/104043008/diff/20001/tests/git_cl_test...
tests/git_cl_test.py:149: ((['git', 'config', 'rietveld.autoupdate'],),
nit: make this one line?

[commit-bot: I haz the power, 2014-01-03 22:22:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pgervais@chromium.org/104043008/70001

[commit-bot: I haz the power, 2014-01-03 22:23:42]

Change committed as 242943