Issue 1040413003: Shell: Remove the test child stuff.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1040413003: Shell: Remove the test child stuff. (Closed)

Created:
5 years, 8 months ago by viettrungluu

Modified:
5 years, 8 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Shell: Remove the test child stuff. Make the lone existing test "app child"-specific. This is an intermediate step towards removing the generic child process abstraction. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6d948cc9e594151f6a7ace2caeb3215541fd93a3

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -150 lines)			Patch
M	shell/BUILD.gn	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	shell/app_child_process.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	shell/app_child_process.mojom	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	shell/app_child_process_host.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	shell/app_child_process_host.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A +	shell/app_child_process_host_unittest.cc	View	2 chunks	+23 lines, -22 lines	0 comments	Download
M	shell/child_process.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	shell/child_process.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	shell/child_process_host.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
D	shell/child_process_host_unittest.cc	View	1 chunk	+0 lines, -62 lines	0 comments	Download
M	shell/shell_test_main.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
D	shell/test_child_process.h	View	1 chunk	+0 lines, -28 lines	0 comments	Download
D	shell/test_child_process.cc	View	1 chunk	+0 lines, -28 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 8 months ago (2015-03-31 17:48:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6d948cc9e594151f6a7ace2caeb3215541fd93a3 (presubmit successful).

Expand Messages | Collapse Messages