Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2124)

Issue 1040393002: The Java Client should be aware of the readback status. (Closed)

Created:
5 years, 8 months ago by patro
Modified:
5 years, 8 months ago
Reviewers:
AKV, no sievers, davidben
CC:
chromium-reviews, darin-cc_chromium.org, jam, sivag, AKVT
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The Java Client should be aware of the readback status. The ReadBack response should be notified to the Java Client to make necessary decisions. BUG=472457 Committed: https://crrev.com/f9747e19ad48dfb99c3a4a09e690d67502204cd7 Cr-Commit-Position: refs/heads/master@{#324214}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Fixed build errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M content/browser/android/content_readback_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content.gyp View 2 chunks +9 lines, -0 lines 0 comments Download
M content/public/android/BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java View 1 2 5 chunks +6 lines, -5 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewReadbackTest.java View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/readback_types.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
patro
Kindly Review, Thanks Shyam Patro
5 years, 8 months ago (2015-03-31 13:21:59 UTC) #2
no sievers
lgtm
5 years, 8 months ago (2015-03-31 19:05:20 UTC) #3
davidben
Is there a bug associated with this? I'm not sure what the context is here.
5 years, 8 months ago (2015-03-31 19:14:02 UTC) #4
patro
On 2015/03/31 19:14:02, David Benjamin wrote: > Is there a bug associated with this? I'm ...
5 years, 8 months ago (2015-04-01 05:51:11 UTC) #5
AKV
https://codereview.chromium.org/1040393002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java File content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java (right): https://codereview.chromium.org/1040393002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java#newcode28 content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java:28: * failure. Please update doxygn description corresponds to newly ...
5 years, 8 months ago (2015-04-01 14:49:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040393002/20001
5 years, 8 months ago (2015-04-02 08:51:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/57885)
5 years, 8 months ago (2015-04-02 09:04:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040393002/40001
5 years, 8 months ago (2015-04-08 09:21:52 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-08 11:48:14 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 11:48:59 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f9747e19ad48dfb99c3a4a09e690d67502204cd7
Cr-Commit-Position: refs/heads/master@{#324214}

Powered by Google App Engine
This is Rietveld 408576698