build/gyp_chromium - Issue 104033004: Re-enable GN as part of GYP execution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/gyp_chromium

Issue 104033004: Re-enable GN as part of GYP execution. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/gyp_chromium

diff --git a/build/gyp_chromium b/build/gyp_chromium

index 8ed0799ec0d86c65d3a657859eba207586291394..434a9b82918a619eee1cda273dcdb29ce7e35813 100755

--- a/build/gyp_chromium

+++ b/build/gyp_chromium

@@ -221,10 +221,8 @@ if __name__ == '__main__':

supplemental_includes = GetSupplementalFiles()

- # Temporarily disabled, http://crbug.com/326146

- # TODO(brettw) re-enable this code

- #if not RunGN(supplemental_includes):

- #sys.exit(1)

+ if not RunGN(supplemental_includes):

+ sys.exit(1)

args.extend(

['-I' + i for i in additional_include_files(supplemental_includes, args)])

« no previous file with comments | « no previous file | no next file » | no next file with comments »