Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 104023011: Introduce kGCCallbackForced flag. (Closed)

Created:
7 years ago by Vyacheslav Egorov (Chromium)
Modified:
6 years, 11 months ago
CC:
v8-dev, Paweł Hajdan Jr., Mads Ager (chromium)
Visibility:
Public.

Description

Introduce kGCCallbackForced flag. This flag will be passed to GC prologue/epilogue callbacks if GC was forced through GC extension. BUG= R=dcarney@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18558

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -26 lines) Patch
M include/v8.h View 1 chunk +2 lines, -1 line 2 comments Download
M src/extensions/gc-extension.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/heap.h View 4 chunks +19 lines, -10 lines 0 comments Download
M src/heap.cc View 6 chunks +16 lines, -10 lines 0 comments Download
M src/heap-inl.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Vyacheslav Egorov (Chromium)
Please take a look.
7 years ago (2013-12-05 12:59:22 UTC) #1
dcarney
lgtm I think mstarzinger wanted kGCCallbackForced renamed to something else though
7 years ago (2013-12-05 13:07:14 UTC) #2
Vyacheslav Egorov (Chromium)
I think we agreed not to rename it. Michael wanted to use the same flag ...
7 years ago (2013-12-05 13:37:34 UTC) #3
Michael Starzinger
LGTM, just a not about the name. https://codereview.chromium.org/104023011/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/104023011/diff/1/include/v8.h#newcode4115 include/v8.h:4115: kGCCallbackForced = ...
6 years, 11 months ago (2014-01-07 13:44:39 UTC) #4
Vyacheslav Egorov (Google)
Thanks for the review Michael & Dan! Landing https://codereview.chromium.org/104023011/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/104023011/diff/1/include/v8.h#newcode4115 include/v8.h:4115: kGCCallbackForced ...
6 years, 11 months ago (2014-01-13 10:44:17 UTC) #5
Vyacheslav Egorov (Chromium)
6 years, 11 months ago (2014-01-13 10:57:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r18558 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698