Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1040193004: Add utility functions for forking new PID namespaces. (Closed)

Created:
5 years, 8 months ago by rickyz (no longer on Chrome)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add utility functions for forking new PID namespaces. Also cleans up Credentials::SetCapabilities. This change was split out of https://codereview.chromium.org/868233011/, which was reverted due to a kernel bug. BUG=460972 Committed: https://crrev.com/ce8969517c091252c32c9af5b3dcb57eb17d431f Cr-Commit-Position: refs/heads/master@{#323164}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -37 lines) Patch
M sandbox/linux/services/credentials.h View 2 chunks +17 lines, -9 lines 0 comments Download
M sandbox/linux/services/credentials.cc View 4 chunks +32 lines, -19 lines 0 comments Download
M sandbox/linux/services/credentials_unittest.cc View 3 chunks +12 lines, -9 lines 0 comments Download
M sandbox/linux/services/namespace_sandbox.h View 3 chunks +36 lines, -0 lines 0 comments Download
M sandbox/linux/services/namespace_sandbox.cc View 4 chunks +76 lines, -0 lines 0 comments Download
M sandbox/linux/services/namespace_sandbox_unittest.cc View 2 chunks +94 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rickyz (no longer on Chrome)
I split the namespace_sandbox/credentials changes out as Julien suggested.
5 years, 8 months ago (2015-03-31 07:07:38 UTC) #2
jln (very slow on Chromium)
Goodness, that was quick! :) lgtm, assuming that there are no changes from the previous ...
5 years, 8 months ago (2015-03-31 18:09:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040193004/1
5 years, 8 months ago (2015-04-01 00:54:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 01:34:15 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 01:35:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce8969517c091252c32c9af5b3dcb57eb17d431f
Cr-Commit-Position: refs/heads/master@{#323164}

Powered by Google App Engine
This is Rietveld 408576698