Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1040193002: crashpad_minidump_test: depend on crashpad_util_test_lib (library) (Closed)

Created:
5 years, 8 months ago by Mark Mentovai
Modified:
5 years, 8 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M handler/handler.gyp View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
5 years, 8 months ago (2015-03-30 21:19:07 UTC) #2
Robert Sesek
lgtm
5 years, 8 months ago (2015-03-31 22:52:04 UTC) #3
Mark Mentovai
The minidump.gyp portion got fixed in 809ea8158dd3, so I’ve removed that from this change and ...
5 years, 8 months ago (2015-03-31 23:08:10 UTC) #4
Mark Mentovai
5 years, 8 months ago (2015-03-31 23:08:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
961141f4f585f51460acc95479e190562082ae35 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698