Issue 1040163002: RawChannelPosix: Close handles only if they are sent successfully.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1040163002: RawChannelPosix: Close handles only if they are sent successfully. (Closed)

Created:
5 years, 8 months ago by Hajime Morrita

Modified:
5 years, 8 months ago

Reviewers:
jamesr

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

RawChannelPosix: Close handles only if they are sent successfully. This is a cherry picking from: https://chromium.googlesource.com/external/mojo.git/+/bc64edb898fc90531ce5bb6be023a80dd42cf0fc This is to fix 466814 without waiting next Mojo roll. R=jamesr@chromium.org BUG=466814 Committed: https://crrev.com/bee8ad8ef91f7631fe64337bf5b5c7516c0f5204 Cr-Commit-Position: refs/heads/master@{#322849}

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	third_party/mojo/src/mojo/edk/system/raw_channel_posix.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040163002/1

5 years, 8 months ago (2015-03-30 20:14:45 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-03-30 20:26:01 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/bee8ad8ef91f7631fe64337bf5b5c7516c0f5204
Cr-Commit-Position: refs/heads/master@{#322849}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages