chrome/browser/resources/chromeos/login/screen_gaia_signin.html - Issue 1040143002: Gaia loading screen changed to align with new Sync screen UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/login/screen_gaia_signin.html

Issue 1040143002: Gaia loading screen changed to align with new Sync screen UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Polymer throbber reused. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/login/login_resources.html ('K') | « chrome/browser/resources/chromeos/login/screen_gaia_signin.css ('k') | chrome/browser/resources/chromeos/login/screen_gaia_signin.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/login/screen_gaia_signin.html

diff --git a/chrome/browser/resources/chromeos/login/screen_gaia_signin.html b/chrome/browser/resources/chromeos/login/screen_gaia_signin.html

index ce4313e75bbeb03b23be8568147dff56e928223b..944cf5e8b12cc0386b91d07e08c18b1e723b563d 100644

--- a/chrome/browser/resources/chromeos/login/screen_gaia_signin.html

+++ b/chrome/browser/resources/chromeos/login/screen_gaia_signin.html

@@ -29,6 +29,7 @@

</div>

+ <throbber-notice text=""></throbber-notice>

dzhioev (left Google) 2015/04/02 18:10:45 nit: I believe you can just drop 'text' attribute.

Nikita (slow) 2015/04/03 11:21:49 This should have "Please wait..." text https://cod

merkulova 2015/04/03 14:58:23 Done.

</div>