Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1040143002: Gaia loading screen changed to align with new Sync screen UI. (Closed)

Created:
5 years, 8 months ago by merkulova
Modified:
5 years, 8 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gaia loading screen changed to align with new Sync screen UI. BUG=470114 TBR=nkostylev@chromium.org,cpu@chromium.org

Patch Set 1 #

Patch Set 2 : Polymer throbber reused. #

Total comments: 6

Patch Set 3 : Comments addressed. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M chrome/app/chromeos_strings.grdp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.html View 1 1 chunk +1 line, -0 lines 1 comment Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.css View 1 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/throbber_notice.html View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
merkulova
5 years, 8 months ago (2015-03-30 16:35:16 UTC) #2
dzhioev (left Google)
On 2015/03/30 16:35:16, merkulova wrote: Can't you reuse <throbber-notice> element, that you've implemented before?
5 years, 8 months ago (2015-04-01 20:28:48 UTC) #3
merkulova
5 years, 8 months ago (2015-04-02 09:26:09 UTC) #4
dzhioev (left Google)
LGTM with nits https://codereview.chromium.org/1040143002/diff/20001/chrome/browser/resources/chromeos/login/login_resources.html File chrome/browser/resources/chromeos/login/login_resources.html (right): https://codereview.chromium.org/1040143002/diff/20001/chrome/browser/resources/chromeos/login/login_resources.html#newcode44 chrome/browser/resources/chromeos/login/login_resources.html:44: <link rel="import" href="chrome://resources/polymer/paper-spinner/paper-spinner.html"> nit: are these ...
5 years, 8 months ago (2015-04-02 18:10:45 UTC) #5
Nikita (slow)
https://codereview.chromium.org/1040143002/diff/20001/chrome/browser/resources/chromeos/login/custom_elements.html File chrome/browser/resources/chromeos/login/custom_elements.html (left): https://codereview.chromium.org/1040143002/diff/20001/chrome/browser/resources/chromeos/login/custom_elements.html#oldcode6 chrome/browser/resources/chromeos/login/custom_elements.html:6: <include src="throbber_notice.html"> Please leave custom polymer element here.
5 years, 8 months ago (2015-04-03 11:20:40 UTC) #7
Nikita (slow)
https://codereview.chromium.org/1040143002/diff/20001/chrome/browser/resources/chromeos/login/screen_gaia_signin.html File chrome/browser/resources/chromeos/login/screen_gaia_signin.html (right): https://codereview.chromium.org/1040143002/diff/20001/chrome/browser/resources/chromeos/login/screen_gaia_signin.html#newcode32 chrome/browser/resources/chromeos/login/screen_gaia_signin.html:32: <throbber-notice text=""></throbber-notice> On 2015/04/02 18:10:45, dzhioev wrote: > nit: ...
5 years, 8 months ago (2015-04-03 11:21:49 UTC) #8
merkulova
https://codereview.chromium.org/1040143002/diff/20001/chrome/browser/resources/chromeos/login/login_resources.html File chrome/browser/resources/chromeos/login/login_resources.html (right): https://codereview.chromium.org/1040143002/diff/20001/chrome/browser/resources/chromeos/login/login_resources.html#newcode44 chrome/browser/resources/chromeos/login/login_resources.html:44: <link rel="import" href="chrome://resources/polymer/paper-spinner/paper-spinner.html"> On 2015/04/02 18:10:45, dzhioev wrote: > ...
5 years, 8 months ago (2015-04-03 14:58:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040143002/40001
5 years, 8 months ago (2015-04-03 14:58:35 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/4545)
5 years, 8 months ago (2015-04-03 18:19:40 UTC) #14
Nikita (slow)
https://codereview.chromium.org/1040143002/diff/40001/chrome/browser/resources/chromeos/login/oobe.html File chrome/browser/resources/chromeos/login/oobe.html (right): https://codereview.chromium.org/1040143002/diff/40001/chrome/browser/resources/chromeos/login/oobe.html#newcode11 chrome/browser/resources/chromeos/login/oobe.html:11: <include src="throbber_notice.html"> not needed here as it's already part ...
5 years, 8 months ago (2015-04-06 11:06:14 UTC) #15
Nikita (slow)
I'll grab this CL and re-land it.
5 years, 8 months ago (2015-04-06 14:43:53 UTC) #16
Nikita (slow)
5 years, 8 months ago (2015-04-07 10:22:52 UTC) #17

Powered by Google App Engine
This is Rietveld 408576698