Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1040133002: Small change to move GrProcessor and GrBatch pools over to SkSpinlock (Closed)

Created:
5 years, 8 months ago by joshua.litt
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Small change to move GrProcessor and GrBatch pools over to SkSpinlock BUG=skia: Committed: https://skia.googlesource.com/skia/+/23ac62c83a49d675a38f1c20462b5537f3c8af01

Patch Set 1 #

Total comments: 3

Patch Set 2 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M src/gpu/GrBatch.cpp View 1 1 chunk +14 lines, -7 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
joshualitt
The benefit here is pretty variable depending on the mutex cost per platform, but its ...
5 years, 8 months ago (2015-03-30 15:20:12 UTC) #3
bsalomon
https://codereview.chromium.org/1040133002/diff/1/src/gpu/GrProcessor.cpp File src/gpu/GrProcessor.cpp (left): https://codereview.chromium.org/1040133002/diff/1/src/gpu/GrProcessor.cpp#oldcode100 src/gpu/GrProcessor.cpp:100: // We use a global pool protected by a ...
5 years, 8 months ago (2015-03-30 15:21:03 UTC) #4
bsalomon
otherwise lgtm
5 years, 8 months ago (2015-03-30 15:21:18 UTC) #5
mtklein
https://codereview.chromium.org/1040133002/diff/1/src/gpu/GrBatch.cpp File src/gpu/GrBatch.cpp (right): https://codereview.chromium.org/1040133002/diff/1/src/gpu/GrBatch.cpp#newcode23 src/gpu/GrBatch.cpp:23: static SkSpinlock gBatchSpinlock; Slightly nicer to use SK_DECLARE_STATIC_SPINLOCK(gBatchSpinlock); Today ...
5 years, 8 months ago (2015-03-30 15:24:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040133002/20001
5 years, 8 months ago (2015-03-30 16:48:28 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 16:53:52 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/23ac62c83a49d675a38f1c20462b5537f3c8af01

Powered by Google App Engine
This is Rietveld 408576698