[Password Manager] Fix to resolve DCHECK when seeing '\n' character in a saved credential username.

[Password Manager] Fix to resolve DCHECK when seeing '\n' character in a saved credential username.

With present implementation the autofill suggestions get elided to fit within the screen bounds. Same (elided text "user␤") being compared with actual suggestion values ("user\n") at the time of selecting suggestions, that apparently fails and results into browser abort with DCHECK.

With this patch we pass actual suggestion value string instead of elided text to DidSelectSuggestion() avoiding DCHECK failure.

BUG=458178
Committed: https://crrev.com/a00232759e5d75b0c56d8b9e6e66b8f7c5a01ab5
Cr-Commit-Position: refs/heads/master@{#323114}

[Pritam Nikam, 2015-03-31 06:51:46]

Patchset #1 (id:1) has been deleted

[Pritam Nikam, 2015-03-31 06:52:48]

pritam.nikam@samsung.com changed reviewers:
+ vabr@chromium.org

[Pritam Nikam, 2015-03-31 06:54:13]

Hi Vaclav,

With this patch issue gets resolve, please have a look at CL.
Thanks!

[vabr (Chromium), 2015-03-31 10:36:36]

Thanks, Pritam Nikam.

This looks reasonable to me, but you need somebody from
chrome/browser/ui/autofill/OWNERS to review.

Cheers,
Vvaclav

[Pritam Nikam, 2015-03-31 13:09:20]

pritam.nikam@samsung.com changed reviewers:
+ isherman@chromium.org

[Pritam Nikam, 2015-03-31 13:09:21]

Hi Ilya,

PTAL, thanks!

[Ilya Sherman, 2015-03-31 20:34:16]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2015-03-31 20:34:17]

lgtm

[commit-bot: I haz the power, 2015-03-31 20:35:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1040083003/20001

[commit-bot: I haz the power, 2015-03-31 21:28:35]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2015-03-31 21:29:44]

Patchset 1 (id:??) landed as
https://crrev.com/a00232759e5d75b0c56d8b9e6e66b8f7c5a01ab5
Cr-Commit-Position: refs/heads/master@{#323114}