Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1040043002: ensure maybe results are checked in v8.h (Closed)

Created:
5 years, 8 months ago by dcarney
Modified:
5 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ensure maybe results are checked in v8.h also some drive-by handlescope fixes in api.cc R=svenpanne@chromium.org BUG= Committed: https://crrev.com/f303b81bde52ba45228aa26a69a2ac25c01c10b3 Cr-Commit-Position: refs/heads/master@{#27510}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -148 lines) Patch
M include/v8.h View 1 2 3 4 44 chunks +136 lines, -93 lines 0 comments Download
M src/api.cc View 1 7 chunks +47 lines, -55 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcarney
ptal
5 years, 8 months ago (2015-03-30 08:52:27 UTC) #2
Sven Panne
lgtm
5 years, 8 months ago (2015-03-30 09:12:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1040043002/80001
5 years, 8 months ago (2015-03-30 09:14:43 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 8 months ago (2015-03-30 09:15:59 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 09:16:19 UTC) #7
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f303b81bde52ba45228aa26a69a2ac25c01c10b3
Cr-Commit-Position: refs/heads/master@{#27510}

Powered by Google App Engine
This is Rietveld 408576698