Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1039963003: [tracing] child-process-side impl for inter-process memory dumps (Closed)

Created:
5 years, 8 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 8 months ago
Reviewers:
dsinclair, nduca
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, Andrew Hayden (chromium.org), picksi1
Base URL:
https://chromium.googlesource.com/chromium/src.git@ipc_3_messages
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] child-process-side impl for inter-process memory dumps This CL introduces the implementation for handling the inter-process memory dumps on the child-process side. Conceptually this consists of a simple plumbing in TraceMessageFilter in order to propagate the request up to the browser's MemoryDumpManager, as the child processes' MDM play a very passive role in the inter-process coordination game. In practice, some extra care is required to match the lifetime of MDM MDM (long) and ChildTraceMessageFilter (shorter) in a thread-safe manner, which requires the introduction of the proxy class herein called ChildMemoryDumpManagerDelegateImpl. More context and design doc are available in the attached BUG. Reason for NOTRY: all but one bots are green. I started goo.gl/tBX5f1 on infra-dev about the failure and it seems due to a bot out of space. The change has been sitting for 4+ hours and there are other CLs blocked on this. BUG=462930, 474973 NOTRY=true Committed: https://crrev.com/f2f5ca37b0b57ffcc91abad73b6c81e82e0c2511 Cr-Commit-Position: refs/heads/master@{#324229}

Patch Set 1 : #

Patch Set 2 : Rebase #

Patch Set 3 : Fix #

Total comments: 4

Patch Set 4 : Rebase + nits #

Patch Set 5 : Fix tracing_nacl.gyp #

Patch Set 6 : Add temporary workaround for crbug.com/474973 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -10 lines) Patch
M base/trace_event/memory_dump_manager.cc View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M components/tracing.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M components/tracing/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A components/tracing/child_memory_dump_manager_delegate_impl.h View 1 2 3 1 chunk +56 lines, -0 lines 0 comments Download
A components/tracing/child_memory_dump_manager_delegate_impl.cc View 1 2 3 1 chunk +71 lines, -0 lines 0 comments Download
M components/tracing/child_trace_message_filter.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M components/tracing/child_trace_message_filter.cc View 1 4 chunks +27 lines, -9 lines 0 comments Download
M components/tracing_nacl.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
nduca
non-exhaustive owner lgtm. would be good to get someone to second-eye on the details.
5 years, 8 months ago (2015-03-30 20:01:36 UTC) #3
Primiano Tucci (use gerrit)
This is a set of 5 CLs (+ another couple for tests) to implement IPC ...
5 years, 8 months ago (2015-03-31 23:30:33 UTC) #4
dsinclair
lgtm w/ nits. https://codereview.chromium.org/1039963003/diff/60001/components/tracing/child_memory_dump_manager_delegate_impl.cc File components/tracing/child_memory_dump_manager_delegate_impl.cc (right): https://codereview.chromium.org/1039963003/diff/60001/components/tracing/child_memory_dump_manager_delegate_impl.cc#newcode49 components/tracing/child_memory_dump_manager_delegate_impl.cc:49: // Make sure we access |ctmf_| ...
5 years, 8 months ago (2015-04-03 00:31:14 UTC) #6
Primiano Tucci (use gerrit)
https://codereview.chromium.org/1039963003/diff/60001/components/tracing/child_memory_dump_manager_delegate_impl.cc File components/tracing/child_memory_dump_manager_delegate_impl.cc (right): https://codereview.chromium.org/1039963003/diff/60001/components/tracing/child_memory_dump_manager_delegate_impl.cc#newcode49 components/tracing/child_memory_dump_manager_delegate_impl.cc:49: // Make sure we access |ctmf_| only on the ...
5 years, 8 months ago (2015-04-03 18:00:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039963003/100001
5 years, 8 months ago (2015-04-07 07:57:50 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/5122)
5 years, 8 months ago (2015-04-07 09:04:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039963003/120001
5 years, 8 months ago (2015-04-08 10:53:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039963003/120001
5 years, 8 months ago (2015-04-08 15:09:44 UTC) #18
commit-bot: I haz the power
Committed patchset #6 (id:120001)
5 years, 8 months ago (2015-04-08 15:10:50 UTC) #19
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 16:05:37 UTC) #20
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/f2f5ca37b0b57ffcc91abad73b6c81e82e0c2511
Cr-Commit-Position: refs/heads/master@{#324229}

Powered by Google App Engine
This is Rietveld 408576698